Add --no-focus flag to native:run command#93
Merged
simonhamp merged 3 commits intoNativePHP:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
Author
|
The failing test is also failing on main, afaict. |
Collaborator
|
Holy cow! Matt spotted in the wild 👀 Will review tomorrow. Thanks 🙏 |
simonhamp
approved these changes
Mar 4, 2026
Member
simonhamp
left a comment
simonhamp
left a comment
There was a problem hiding this comment.
Thanks @mattstauffer 🙏🏼 I have applied the test fix here for ease
Contributor
Author
|
Amazing! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I'm developing locally, the window constantly steals focus whenever I make any changes.
This PR adds a
--no-focusparameter to thenative:runcommand.I have tested this locally, but this is my first NativePHP app, so I'm not 100% confident I did it right. But it seems to work on my machine, for what that's worth.