Skip to content

Add support for nested meta-data inside android manifest components#5

Open
Mallon94 wants to merge 2 commits intoNativePHP:mainfrom
Mallon94:main
Open

Add support for nested meta-data inside android manifest components#5
Mallon94 wants to merge 2 commits intoNativePHP:mainfrom
Mallon94:main

Conversation

@Mallon94
Copy link
Contributor

@Mallon94 Mallon94 commented Feb 1, 2026 •
edited
Loading

Problem

  • Some android services need additional meta-data within the service level of the manifest.

Solution

  • Added buildComponentMetaData function to place in nested metadata. Can be used in future for other components in the manifest if they need nested meta-data.

simonhamp
simonhamp requested changes Feb 23, 2026
View reviewed changes
Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to cover this

@Mallon94
Add tests for handling meta-data in Android service components, inclu…
e289c9d 
…ding value and resource attributes, boolean values, kebab-case keys, and intent filters.
@Mallon94 Mallon94 requested a review from simonhamp February 25, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonhamp simonhamp Awaiting requested review from simonhamp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mallon94 @simonhamp