Skip to content

Conversation

@yujeong-jeon
Copy link
Contributor

@yujeong-jeon yujeong-jeon commented Jun 25, 2025

Related Issue

  • #

Describe your changes

  1. Fix CLI binary download path:
  • Updated downloadBinary.js to correctly construct the binary download URL from GitHub Releases.
  • Improved logic to select the appropriate binary based on platform and architecture.
  1. Add debugging logs to postinstall script:
  • Added console.log to display the status of each step during postinstall execution.
  • Clearly verify the downloaded binary path and execution permission status.
  1. Improve workflow in release.yaml:
  • Adjusted getReleaseUploadUrl and upload-release-asset steps to only execute when both steps.changesets.outputs.published and env.commithelperGoWillBePublished conditions are met.
  • Enhanced workflow efficiency by preventing unnecessary step executions.
  1. Fix CLI execution path:
  • Adjusted cli.js to ensure the binary executes from the correct path. (Due to the limitation of bin field)
  • Resolved execution errors caused by incorrect paths.
  1. Update package.json configuration:
  • Configured the "files" field to include only necessary directories.
  • Included the scripts/ directory to ensure the postinstall script functions correctly.
  1. Resolve binary execution permission issues:
  • Explicitly added chmod +x to grant execution permissions to the downloaded binary.
  • Prevented errors caused by insufficient execution permissions.
  1. Enhance debugging and testing:
  • Provided guidance to use npm_config_loglevel=info to view postinstall script execution logs.
  • Added logic to verify the validity of the downloaded file and the result of the curl command.

Request

@yujeong-jeon yujeong-jeon requested a review from a team as a code owner June 25, 2025 03:57
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

npayfebot commented Jun 25, 2025

✅ Changeset detected

Latest commit: c57247b

@naverpay/commithelper-go package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@naverpay/commithelper-go 💥 Major
powered by: naverpay changeset detect-add actions

yceffort-naver
yceffort-naver previously approved these changes Jun 25, 2025
Copy link
Collaborator

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"name": "@naverpay/commit-helper",

@naverpay/commit-helper-go ?
@naverpay/commithelper-go ?

@yujeong-jeon
Copy link
Contributor Author

Personally, it's uncomfortable to type '-' twice, so I added '-' to the front of 'go' lol 😅

@yceffort-naver
Copy link
Collaborator

agreed.

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from 4351eb4 to d28dbfe Compare June 25, 2025 04:36
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from d28dbfe to 7e38877 Compare June 25, 2025 04:43
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from 7e38877 to 4709e11 Compare June 25, 2025 05:11
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from 4709e11 to 446dad7 Compare June 25, 2025 05:52
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-c4107dc

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from c4107dc to 3f7cf49 Compare June 25, 2025 08:19
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-3f7cf49

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from 3f7cf49 to a1c315d Compare June 25, 2025 08:29
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-a1c315d

@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-9967fbe

@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-249f678

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from 249f678 to a82d0e8 Compare June 25, 2025 09:59
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-a82d0e8

@yujeong-jeon yujeong-jeon force-pushed the pub/commithelper-go branch from 01385ec to c57247b Compare June 25, 2025 10:24
@yujeong-jeon
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link

Published Canary Packages

@naverpay/commithelper-go@1.0.0-rc.250625-c57247b

@yujeong-jeon
Copy link
Contributor Author

yujeong-jeon commented Jun 25, 2025

Done... Use this version @naverpay/commithelper-go@1.0.0-rc.250625-c57247b

Copy link

@yceffort yceffort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄱㄱㄱ

Copy link
Collaborator

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄱㄱㄱㄱ

@yujeong-jeon yujeong-jeon merged commit 29cd33c into main Jul 4, 2025
3 checks passed
@yujeong-jeon yujeong-jeon deleted the pub/commithelper-go branch July 4, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants