Support ble extended advertising on Windows

[rohitsangwan01]

PR Type

enhancement

---

Description

• Added support for Bluetooth Low Energy (BLE) extended advertisements on Windows by modifying the BluetoothLEAdvertisementWatcher to allow extended advertisements.
• This enhancement enables the use of extended advertising features in BLE applications on Windows.

---

Changes walkthrough 📝

	Relevant files
Enhancement	universal_ble_plugin.cpp Enable BLE extended advertisements on Windows                        windows/src/universal_ble_plugin.cpp Added support for allowing extended advertisements in Bluetooth LE. Modified the BluetoothLEAdvertisementWatcher to enable extended advertisements. +1/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The return value from AllowExtendedAdvertisements() is explicitly discarded using (void). Consider handling potential errors that may occur when enabling extended advertisements.

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Handle potential failures when enabling a feature instead of silently ignoring them Check the return value of AllowExtendedAdvertisements() to handle potential failures in enabling extended advertisements. Ignoring the return value with a void cast is not recommended. windows/src/universal_ble_plugin.cpp [110] -(void)bluetoothLEWatcher.AllowExtendedAdvertisements(); +if (!bluetoothLEWatcher.AllowExtendedAdvertisements()) { + // Handle the failure case appropriately + throw std::runtime_error("Failed to enable extended advertisements"); +} Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies a potential reliability issue where failures in enabling extended advertisements are being silently ignored. Adding error handling is crucial for robust Bluetooth functionality.	8

💡 Need additional feedback ? start a PR chat

[fotiDim]

/gemini review

[gemini-code-assist]

Code Review

The pull request adds support for Bluetooth Low Energy (BLE) extended advertisements on Windows. The changes are minimal, focusing on enabling the AllowExtendedAdvertisements feature. Overall, the change seems straightforward and beneficial.

Merge Readiness

The pull request appears to be a small but important enhancement. Given the limited scope and the absence of any identified high or critical severity issues, the pull request seems to be in good shape for merging. However, it's advisable to have another reviewer double-check the correctness of the added line, especially concerning its potential impact on existing functionality. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

[gemini-code-assist]

It's good to see that the return value of AllowExtendedAdvertisements() is being ignored, as it might not always be necessary to handle it explicitly. However, consider adding a comment explaining why the return value is being ignored. This can help avoid confusion for future developers who might wonder if the return value should be checked for errors or other status information.

Suggested change

	(void)bluetoothLEWatcher.AllowExtendedAdvertisements();
	(void)bluetoothLEWatcher.AllowExtendedAdvertisements(); // Ignoring return value as it doesn't provide useful information in this context.