This repository was archived by the owner on Jan 5, 2026. It is now read-only.
feat(AwesomeMap): add player head color border and class color mapping#31
Merged
Yqloss merged 6 commits intoNecron-Dev:mainfrom Sep 13, 2025
Merged
feat(AwesomeMap): add player head color border and class color mapping#31Yqloss merged 6 commits intoNecron-Dev:mainfrom
Yqloss merged 6 commits intoNecron-Dev:mainfrom
Conversation
Contributor
Xmarmalade
commented
Aug 24, 2025
Xmarmalade
commented
ench233
suggested changes
Aug 24, 2025
Contributor
ench233
left a comment
ench233
left a comment
There was a problem hiding this comment.
🚀 感谢你对 EnchAddons 的贡献！
下面是对于你贡献的代码的一些建议喵：
- 请使用 IDEA 插件
KtLint完全格式化代码。 - 请将常量在同 .kt 文件内以 Top-Level 定义而不是放在 object 中
- 请不要使用
println()输出日志 - 请在调用 NanoVGWrapper 前使用
OneColor而不是Int来传递颜色 - 请将 玩家职业 包装为 Enum 并在其中实现
getClassColor(DungeonClass):OneColor而不是getClassColor(Char):Int - 请将类似于
colorBorderSize这样的 专注于渲染的 配置项直接实现而不是 override
以上，祝好喵。
ench233
suggested changes
Aug 26, 2025
| val borderColor = getClassColor(player.dungeonClass) alphaScale mapAlpha | ||
| val borderSize = config.colorBorderSize.double | ||
| val borderColor = getClassColor(DungeonClass.fromCode(player.dungeonClass)) | ||
| val borderSize = 1.0 // Direct implementation instead of config override |
| else -> { | ||
| println("[AwesomeMap Debug] Unknown class: '$classInfo'") | ||
| '?' | ||
| dungeonClass = |
| if (dungeonClass != '?') { | ||
| println("[AwesomeMap Debug] Updated class for $name: $dungeonClass") | ||
| } | ||
| dungeonClass = |
Yqloss
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.