Skip to content

fix: update package-lock.json, enhance CI pipeline, and add check-typ…#36

Merged
FabianSanchezD merged 1 commit intoNeko-Protocol:mainfrom
DanielCotoJ:fix/ci-repo-health
Feb 28, 2026
Merged

fix: update package-lock.json, enhance CI pipeline, and add check-typ…#36
FabianSanchezD merged 1 commit intoNeko-Protocol:mainfrom
DanielCotoJ:fix/ci-repo-health

Conversation

@DanielCotoJ
Copy link
Contributor

@DanielCotoJ DanielCotoJ commented Feb 28, 2026

🚀 Neko Pull Request

Mark with an x all the checkboxes that apply (like [x])


📌 Type of Change

  • Documentation (updates to README, docs, or comments)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

📝 Changes description

Fix broken builds

  • Aggregator: Added missing imports for HttpModule, EventEmitterModule, and DataReceptionService in apps/aggregator/src/app.module.ts.
  • Ingestor: Added missing import for SchedulerService in apps/ingestor/src/modules/prices.module.ts.
  • Aggregator: Removed unused Inject import in apps/aggregator/src/services/aggregation.service.ts (lint error).

Extend type checking to all workspaces

  • Added "check-types": "tsc --noEmit" script to 6 workspaces: aggregator, api, transactor, ingestor, frontend, signer.
  • Updated turbo.json: check-types task now depends on ^build instead of ^check-types, so dependency type declarations (.d.ts) are available before consumer packages type-check.
  • Created apps/frontend/jest.setup.d.ts to expose @testing-library/jest-dom matcher types for TypeScript.

Add Test step to CI

  • Added a "Test" step (npm test) to .github/workflows/ci.yml after the Build step.
  • Fixed packages/signer/package.json test script with --passWithNoTests (no test files yet).

Clean up duplicate dependencies

  • Removed duplicate axios entry in apps/aggregator/package.json.
  • Removed duplicate @oracle-stocks/shared entry in apps/ingestor/package.json.

Documentation

  • Added "CI / Repo Health" section to README.md with instructions to run the full pipeline locally.

Lockfile

  • Regenerated package-lock.json to reflect dependency fixes.

📸 Evidence (A Loom/Cap video is required as evidence, we WON'T merge if there's no proof)

Full pipeline verified locally:
image
image

Video Evidence:
https://www.loom.com/share/fd5a00ef5db64d19968e58af23c1edc3


⏰ Time spent breakdown

Task Time
Analysis & planning ~15 min
Fix broken imports (aggregator + ingestor) ~5 min
Add check-types to 6 workspaces + turbo.json fix ~10 min
CI workflow + signer test fix ~5 min
Clean duplicates + regenerate lockfile ~10 min
README documentation ~5 min
Verification & debugging (lint, type errors, test failures) ~15 min
Total ~65 min

🌌 Comments

  • The turbo.json change from "dependsOn": ["^check-types"] to "dependsOn": ["^build"] for the check-types task is important: without it, tsc --noEmit in consumer packages (like ingestor) fails because @oracle-stocks/shared hasn't produced its .d.ts files yet.
  • The aggregator worker process teardown warning in tests is pre-existing and unrelated to these changes.
  • The signer package has no tests yet; --passWithNoTests prevents CI from failing until tests are added.

Thank you for contributing to Neko, you just helped us make RWAs consumer friendly on Stellar! We hope you can continue contributing to this project.

Copy link
Contributor

@FabianSanchezD FabianSanchezD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabianSanchezD FabianSanchezD merged commit 7bb5f26 into Neko-Protocol:main Feb 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI and repo health: tests in CI, fix broken imports, typecheck all workspaces

2 participants