-
Notifications
You must be signed in to change notification settings - Fork 71
Add album_artist, year, rating, file_path column to data layer across all providers #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NeptuneHub
merged 40 commits into
NeptuneHub:main
from
rendyhd:feature/album-artist-support
Mar 14, 2026
+5,699
−609
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
126c4f7
Add album_artist column to data layer across all providers
rendyhd 44846c1
Add Docker test stacks and album_artist validation guide
claude 27d356c
Switch AudioMuse test stack to local NVIDIA build
claude 3752779
Use bind mounts under ./providers/ for provider storage
claude 95b68bf
Merge pull request #1 from rendyhd/claude/docker-test-guide-Pa9uc
rendyhd 1d23a29
updated test files
rendyhd 1a4378d
Merge branch 'NeptuneHub:main' into feature/album-artist-support
rendyhd 969cae2
missing base_image
rendyhd b13914b
wrong lyrion port in test compose for audiomuse
rendyhd a1913c9
Fix album_artist API call
rendyhd 4c4f612
Clean test stack
rendyhd c6f2273
Added Year, Rating (for Lyrion and Navidrome), and File Path
rendyhd c7825f6
changed identifier towards Navidrome from version to "AudioMuse" to r…
rendyhd 9b58e3a
clean-up provider test stack
rendyhd 3dd1a9a
clean-up provider test stack
rendyhd aa8ec44
Merge branch 'feature/album-artist-support' of https://github.com/ren…
rendyhd c86778a
Merge branch 'main' into feature/album-artist-support
NeptuneHub 674aff6
fallback logic for DD-MM-YYYY, Rating to 5 star schema, album_name fo…
rendyhd 8204a2f
Merge branch 'main' into feature/album-artist-support
NeptuneHub 6893550
Cherry-pick AI instant playlist overhaul + album support from multi-p…
rendyhd af11f41
AI instant playlist improvements, unit tests, and gitignore testing_s…
rendyhd 96fb5aa
Enforce rating and genre filters strictly in instant playlist
rendyhd 2097f80
updated navidrome identifier
rendyhd c2f11e5
Merge pull request #6 from rendyhd/feature/ai-instant-playlist-upgrade
rendyhd 2b2efe0
Merge branch 'main' into feature/album-artist-support
NeptuneHub 8290bb4
Merge branch 'main' into feature/album-artist-support
NeptuneHub 9e1b317
Fix hardcoded local path in test_playlist_ordering.py
rendyhd aaf9f86
Merge branch 'main' into feature/album-artist-support
rendyhd 27f2c09
Fix genre filter test to match new SUBSTRING-based SQL pattern
rendyhd e6f1183
Index fix
NeptuneHub 88b9c99
Prompt improvement
NeptuneHub 09ca1fe
Unit and Integration test fix
NeptuneHub ccde60b
Merge branch 'main' into feature/album-artist-support
NeptuneHub 70e0a1e
Merge branch 'main' into feature/album-artist-support
NeptuneHub 0b745ad
Merge branch 'main' into feature/album-artist-support
NeptuneHub ceead32
Fix year filter, strict filter fidelity, and progressive artist cap r…
rendyhd 6f4d5b0
Merge branch 'main' into feature/album-artist-support
NeptuneHub aa241ab
Merge branch 'main' into feature/album-artist-support
NeptuneHub d4c30ea
Improve Ollama instant playlist: fix timeout, thinking models, and pr…
rendyhd f59e506
Improve playlist quality: scale routing, genre coherence, iteration c…
rendyhd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added here in the prompt that you have Year and Rating but some line over you have a contradictionary line that say:
The result is that a query like
even with g
emini-2.5-flashthat is fast enough, don't read the year from the database.Please refactor ALL the prompt to use this new data and have it prefear from the "AI BRAINSTORMING" tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! My focus was completely on the data schema, I remember removing it there. Completely missed it above. I'd be happy to spend some time on looking at the complete prompt. I can make a similar test script and iterate through variations and document performance across models.
Have you every looked at using it for specific song suggestions? I know that plexamp used that approach.
Also just thought of the idea that I'd like a killer-prompt that's gonna suggest me new albums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can improve the AI prompt by doing multiple test will be really appreciated. I have the impression that we are not using the Instant Playlist potentiality at all.
I think that the key idea is not using the AI to have the information, but to help you searching between the information that you already have in your database (so searching in the database, or running API, and so on).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been diving into this one in #311
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand: the PR #311 will include the change of this so I can wait it to be finished and test all together?
Thanks!