Refactor section components to use interface type #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComponentSectionProperties now uses IComponentSectionComponentProperties instead of TextDisplayProperties, allowing sections to contain any compatible component type. Updated constructors, properties, methods, and interfaces accordingly. TextDisplayProperties now implements the new interface and supports proper serialization. This generalizes and extends the section component model.
|
The documentation preview is available at https://preview.netcord.dev/239. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the component section model to use interface-based typing instead of concrete types. The ComponentSectionProperties class now accepts IComponentSectionComponentProperties instead of TextDisplayProperties, while TextDisplayProperties implements this new interface with proper serialization support.
- Introduced
IComponentSectionComponentPropertiesinterface implementation toTextDisplayProperties - Updated
ComponentSectionPropertiesto useIComponentSectionComponentPropertiesthroughout its API - Maintained backward compatibility through interface implementation while enabling future extensibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| NetCord/Rest/ComponentProperties/TextDisplayProperties.cs | Implements IComponentSectionComponentProperties interface and adds corresponding serialization method |
| NetCord/Rest/ComponentProperties/ComponentSectionProperties.cs | Refactors all references from concrete TextDisplayProperties type to interface type IComponentSectionComponentProperties in constructor, properties, methods, and internal interfaces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentSectionProperties now uses IComponentSectionComponentProperties instead of TextDisplayProperties, allowing sections to contain any compatible component type. Updated constructors, properties, methods, and interfaces accordingly. TextDisplayProperties now implements the new interface and supports proper serialization. This generalizes and extends the section component model.