feat: add support for post requests for SSE#1122
Merged
berngp merged 1 commit intoNetflix:masterfrom Jul 2, 2022
Merged
Conversation
Contributor
Author
Contributor
Author
|
Thanks for approving, when do you think this'll be merged and released? I was hoping to use in our project fairly soon. |
Contributor
|
@Ancient-Dragon next few days. |
Contributor
Author
|
Great many thanks! |
Contributor
|
Release v5.0.5 should be out soon. |
Contributor
|
@Ancient-Dragon - thanks very much for your contribution. Would you also be able to update the documentation if you have time? It would greatly help us. If not, no worries, we will take care of it. |
Contributor
Author
|
Hi @srinivasankavitha I have created the PR here: Netflix/dgs#100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull request checklist
first
Pull Request type
Changes in this PR
Change existing sse subscriptions to be a get request handler and move common code into a new method then add a post request handler which calls the same code.
Describe the new behavior from this PR, and why it's needed
Issue #236 - the ask was to add documentation but it looks like the feature isn't properly supported. I've added support for post requests (which will probably be the most common usecase)
Alternatives considered
Describe alternative implementation you have considered