add binding host support to jetty integration#374
Open
tcellucci wants to merge 2 commits intoNetflix:masterfrom
Open
add binding host support to jetty integration#374tcellucci wants to merge 2 commits intoNetflix:masterfrom
tcellucci wants to merge 2 commits intoNetflix:masterfrom
Conversation
Committer: Tom Cellucci <tcellucci@nfml-mkh.corp.netflix.com>
elandau
approved these changes
Oct 31, 2017
| Server server = new Server(config.getPort()); | ||
| Server server; | ||
| if (config.getHost() != null) { | ||
| server = new Server(new InetSocketAddress(config.getHost(), config.getPort())); |
twicksell
approved these changes
Oct 31, 2017
qiangdavidliu
approved these changes
Feb 20, 2018
|
|
||
| public interface JettyConfig { | ||
|
|
||
| String getHost(); |
Contributor
There was a problem hiding this comment.
nit: add javadoc for this, especially since it can be null?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer: Tom Cellucci tcellucci@netflix.com