Skip to content

Added a fix to error when creating an invoice for multiple items with… #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
japarece wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added a fix to error when creating an invoice for multiple items with… #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
.vscode
.idea/
.DS_STORE
.DS_STORE
11 changes: 10 additions & 1 deletion Model/Dibs/Items.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,16 @@ public function addItems($items)
$sku = $item->getSku();
//make sku unique (sku could not be unique when we have product with options)
if (isset($this->_cart[$sku])) {
$sku = $sku . '-' . $item->getId();
$itemRefId = $item->getId();
/**
* use related order_item_id or quote_item_id when item id is not set
* error is observed when creating an invoice and there is more than two items with the same sku but with different configurations
* items after the second similar sku will replace the second item instead of appending as a separate item
*/
$itemRefId = $itemRefId ? $itemRefId : $item->getData('order_item_id');
$itemRefId = $itemRefId ? $itemRefId : $item->getData('quote_item_id');
$sku = $sku.'-'.$itemRefId;

}

$itemName = $item->getName();
Expand Down