module draft with HPP integration#55
Closed
konrad-konieczny wants to merge 168 commits intomain-2.0.0from
Closed
Conversation
SQNETS-40: Fix config virtual type
…ETS-32/test-button
# Conflicts: # Gateway/Config/Config.php
SQNETS-32-test-button
SQNETS-32: Create admin view for the module
slawro
reviewed
May 7, 2025
slawro
reviewed
May 7, 2025
slawro
reviewed
May 7, 2025
slawro
reviewed
May 7, 2025
| if ($redirectUrl) { | ||
| $result = json_encode(['result' => $result, 'redirect_url' => $redirectUrl]); | ||
| } | ||
| } catch (Exception $e) { |
There was a problem hiding this comment.
what is the Exception that is expected in the code above?
view/frontend/web/js/view/payment/method-renderer/nexi-method.js
Outdated
Show resolved
Hide resolved
view/frontend/web/js/view/payment/method-renderer/nexi-method.js
Outdated
Show resolved
Hide resolved
SQNETS-72: Missing validation for required fields in payment configuration
…t types and update constructor parameters across multiple classes
…d; set consumer data handling to true in payment request
…dlesConsumerData to true in CreatePaymentRequestBuilder
3413af8 to
3d027d3
Compare
…er and CreatePaymentRequestBuilder
…mentRefundFailed classes
slawro
reviewed
May 15, 2025
| return Component.extend({ | ||
| defaults: { | ||
| template: 'Nexi_Checkout/payment/nexi', | ||
| template: window.checkoutConfig.payment.nexi.integrationType ? 'Nexi_Checkout/payment/nexi-hosted' : 'Nexi_Checkout/payment/nexi-embedded.html', |
There was a problem hiding this comment.
is the html at the end nexi-embedded.html needed?
and please use isHosted method that you added
Collaborator
Author
There was a problem hiding this comment.
the isHosted method seem to not known at this time of creating component, so direct access to checkout config needed here
Collaborator
Author
There was a problem hiding this comment.
and the nexi-embedded template added here for the sake of future use within embedded checkout
slawro
reviewed
May 15, 2025
konrad-konieczny
pushed a commit
that referenced
this pull request
Aug 12, 2025
SQNETS-102: Add Void command to cancel payment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.