feat(security): implement robust XSS sanitization and checksum-valida…#230
Merged
GoSTEAN merged 9 commits intoNetwalls:mainfrom Feb 27, 2026
Merged
Conversation
…ted Stellar addresses closes Netwalls#135
…rules - Replace invalid Stellar key GA5XIGA... with a checksummed valid key GAMCVGJF... across validation.schemas, validation.middleware, and integration tests (the new stellarAddress schema now validates checksum) - Replace non-UUID market IDs (market-1, test-market-id) with valid UUIDs in trading integration tests (uuidParam now validates route params) - Change numeric amount/shares fields to strings in buy/sell tests to match schema expectations (amountUsdc, minShares, shares, minPayout)
Contributor
Author
|
@GoSTEAN please merge |
Contributor
|
@dannyy2000 Resolve conflict |
Contributor
Author
resolved and ci passing, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSS Sanitization: Implemented robust HTML stripping for market titles, descriptions, and user profile fields.
Stellar Address Security: Updated validation to include cryptographic checksum verification using the Stellar SDK.
Standardized Validation: Enforced strict Zod schemas on all trading routes, removing manual and inconsistent checks.
Local Verification: All local checks passed (Lint, Typecheck, and a new security test suite with 13 cases).
closes #135