feat: implement scheduled leaderboard broadcasting (#116)#238
Open
GoodnessJohn wants to merge 2 commits intoNetwalls:mainfrom
Open
feat: implement scheduled leaderboard broadcasting (#116)#238GoodnessJohn wants to merge 2 commits intoNetwalls:mainfrom
GoodnessJohn wants to merge 2 commits intoNetwalls:mainfrom
Conversation
- Add LeaderboardBroadcasterService with 5-minute scheduled broadcasts
- Implement deterministic rank change detection with stable sorting
- Add private achievement notifications via secure user rooms
- Add public aggregated leaderboard updates
- Ensure idempotent behavior with minimum 4-minute gap
- Add resilience to restarts and error recovery
- Integrate with Socket.IO for real-time notifications
- Add user private rooms (user:{userId}) for personal notifications
- Add leaderboard room (leaderboard:global) for public updates
- Add subscribe_leaderboard/unsubscribe_leaderboard events
- Update cron service to start/stop broadcaster
- Update server initialization with Socket.IO and broadcaster
- Add 25 comprehensive tests covering all requirements
- Ensure no sensitive data exposure in public broadcasts
- Implement achievement detection (Top 10, Top 100, Big Climb, Weekly Leader)
- Add status monitoring endpoint
- Ensure backward compatibility with no breaking changes
Contributor
|
@GoodnessJohn rezolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #116