refactor: add sentry dsn rotation logic#466
Merged
Conversation
lsndr
added
Type: refactoring
derevnjuk
requested changes
Oct 5, 2023
Comment on lines
+76
to
+79
| await this.updateConfigFile({ | ||
| ...configFile, | ||
| updatedAt: new Date() | ||
| }); |
Member
There was a problem hiding this comment.
Seems this is redundant. Should we update the configuration as though the rotation was successful?
Member
Author
There was a problem hiding this comment.
I think yes, just because if we don't do that, it will try to perform rotation on every bright-cli call causing at most 1.5 seconds delay.
Since rotation logic is not crucial for the cli for now, I think it's ok in case of failure to repeat it later.
Member
There was a problem hiding this comment.
As you wish. However, I'm still uncertain about how it is supposed to work for long-running processes like the repeater which is intended to work for months.
Member
Author
There was a problem hiding this comment.
Let's have a separate PR for the background rotation
derevnjuk
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates-to: #458