Skip to content

Comments

Support only built-in OS decoders/encoders. Remove any GPL code.#96

Merged
SoylentGraham merged 13 commits intoNewChromantics:masterfrom
EvanRuiz:94-Support-only-built-in-OS-decoders-encoders-remove-any-GPL-code
Feb 21, 2025
Merged

Support only built-in OS decoders/encoders. Remove any GPL code.#96
SoylentGraham merged 13 commits intoNewChromantics:masterfrom
EvanRuiz:94-Support-only-built-in-OS-decoders-encoders-remove-any-GPL-code

Conversation

@EvanRuiz
Copy link
Contributor

@EvanRuiz EvanRuiz commented Feb 18, 2025

  • Broadway and X264 sources and references removed.
  • Updated readme and added open source attributions.
  • It may be easier to review each commit change set separately.
  • Platform builds compile for: Windows, Mac OSX, iOS, Linux (Linux has another PR pending w/ compile fixes)
  • Not tested: Android, Lumin, NVIDIA Jetson, Raspberry Pi, Hololens, Wasm

NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94  Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
@SoylentGraham
Copy link
Member

This kinda looks okay.

Not sure theres any use for a wasm build at all any more with webcodecs. Any webworker implementation that uses the wasm would be just passing VideoFrames around needlessly.

I wonder if theres any value in the API, hmm.

@SoylentGraham
Copy link
Member

does the attribution file need to be specificcly uppercase for github, or can we make it consistent with everything else and be capitalised?

@EvanRuiz
Copy link
Contributor Author

does the attribution file need to be specificcly uppercase for github, or can we make it consistent with everything else and be capitalised?

It looks like it isn't required to be all caps: https://github.com/orgs/community/discussions/22673

I checked the "allow edits by maintainers" - I don't mind if you make commit tweaks on the PR directly, based on your style preferences.

@SoylentGraham
Copy link
Member

Looks like windows isn't compiling. Can be fixed seperately #98

@EvanRuiz
Copy link
Contributor Author

Thanks for the tweaks and review. For Windows - I had tested the build of the windows library and test app - but looks like I didn't run the UWP project build, so didn't notice UWP had a linking error for HEVC.

@EvanRuiz
Copy link
Contributor Author

PR for UWP windows build fix: #99

@EvanRuiz
Copy link
Contributor Author

Not sure theres any use for a wasm build at all any more with webcodecs. Any webworker implementation that uses the wasm would be just passing VideoFrames around needlessly.

I wonder if theres any value in the API, hmm.

I also see the Build Wasm github action failing - with your above comment are you thinking to remove Wasm?

@SoylentGraham
Copy link
Member

Not sure theres any use for a wasm build at all any more with webcodecs. Any webworker implementation that uses the wasm would be just passing VideoFrames around needlessly.
I wonder if theres any value in the API, hmm.

I also see the Build Wasm github action failing - with your above comment are you thinking to remove Wasm?

I'll just leave it in there for now as a stub.

I thought I fixed wasm on master...

@SoylentGraham SoylentGraham merged commit 36f1ccd into NewChromantics:master Feb 21, 2025
10 of 13 checks passed
@EvanRuiz EvanRuiz deleted the 94-Support-only-built-in-OS-decoders-encoders-remove-any-GPL-code branch February 24, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants