Support only built-in OS decoders/encoders. Remove any GPL code.#96
Conversation
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
NewChromantics#94 Support only built-in OS decoders/encoders. Remove any GPL code.
|
This kinda looks okay. Not sure theres any use for a wasm build at all any more with webcodecs. Any webworker implementation that uses the wasm would be just passing VideoFrames around needlessly. I wonder if theres any value in the API, hmm. |
|
does the attribution file need to be specificcly uppercase for github, or can we make it consistent with everything else and be capitalised? |
It looks like it isn't required to be all caps: https://github.com/orgs/community/discussions/22673 I checked the "allow edits by maintainers" - I don't mind if you make commit tweaks on the PR directly, based on your style preferences. |
|
Looks like windows isn't compiling. Can be fixed seperately #98 |
|
Thanks for the tweaks and review. For Windows - I had tested the build of the windows library and test app - but looks like I didn't run the UWP project build, so didn't notice UWP had a linking error for HEVC. |
|
PR for UWP windows build fix: #99 |
I also see the Build Wasm github action failing - with your above comment are you thinking to remove Wasm? |
I'll just leave it in there for now as a stub. I thought I fixed wasm on master... |
…ers-remove-any-GPL-code
Uh oh!
There was an error while loading. Please reload this page.