Skip to content

Comments

[ECWoC] feat: created a resuable footer component, privacy policy, terms and conditions pages#146

Merged
abhishek-nexgen-dev merged 5 commits intoNexGenStudioDev:masterfrom
ShivanshCoding36:master
Jan 29, 2026
Merged

[ECWoC] feat: created a resuable footer component, privacy policy, terms and conditions pages#146
abhishek-nexgen-dev merged 5 commits intoNexGenStudioDev:masterfrom
ShivanshCoding36:master

Conversation

@ShivanshCoding36
Copy link
Contributor

📌 Description

This PR adds a previously missing reusable footer component (added to every page via app.tsx), along with elaborated legal pages: a privacy policy and a Terms and Conditions page.
All these follow the exsisting style of the project.

🔧 Type of Change

Please mark the relevant option(s):

  • ✨ New feature
  • 🎨 UI / Styling change

🧪 How Has This Been Tested?

Describe the tests you ran to verify your changes.

  • Manual testing

✅ Checklist

Please confirm the following:

  • My code follows the project’s coding style
  • I have tested my changes
  • This PR does not introduce breaking changes

@github-actions
Copy link

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ShivanshCoding36, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the LocalMind frontend by introducing crucial structural and legal components. It establishes a consistent user experience across the application by adding a global, reusable footer. Furthermore, it addresses the need for transparency and legal compliance by implementing dedicated pages for the Privacy Policy and Terms & Conditions, making the application more robust and user-friendly.

Highlights

  • Reusable Footer Component: A new Footer component has been created and integrated globally into the App.tsx file, ensuring its presence on all application pages.
  • Legal Pages Implementation: Dedicated pages for "Privacy Policy" and "Terms & Conditions" have been developed, providing essential legal information to users.
  • Route Integration: New routes (/privacy-policy and /terms-conditions) have been added to AppRoutes.tsx to make the newly created legal pages accessible.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ShivanshCoding36
Copy link
Contributor Author

Hi maintainers
This PR is a part of ECWoC
kindly add the required labels.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully introduces a reusable footer component and new pages for the privacy policy and terms & conditions. The overall implementation is good, but I've identified a critical issue with incorrect import paths in AppRoutes.tsx that will prevent the application from compiling. There is also a broken link in the new footer component that needs to be addressed. My review includes detailed comments on these issues, along with suggestions to improve code maintainability by replacing hardcoded values with constants.

Comment on lines +8 to +9
import PrivacyPolicy from './features/Pages/PrivacyPolicy'
import TermsConditions from './features/Pages/TermsConditions'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The import paths for PrivacyPolicy and TermsConditions are incorrect. Based on the project's file structure, the paths should be relative from the current file's location (src/app/routes/) to the components' location (src/features/Dashboard/V1/Component/Pages/). The current paths will cause a module resolution error and break the build.

Suggested change
import PrivacyPolicy from './features/Pages/PrivacyPolicy'
import TermsConditions from './features/Pages/TermsConditions'
import PrivacyPolicy from '../../features/Dashboard/V1/Component/Pages/PrivacyPolicy'
import TermsConditions from '../../features/Dashboard/V1/Component/Pages/TermsConditions'

Comment on lines +29 to +31
<Link to="/docs" className="hover:underline">
Docs
</Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This link points to /docs, but there is no corresponding route defined in AppRoutes.tsx. This will lead to a "404 Not Found" error for users who click it. Please either add the /docs route or remove this link until the page is implemented.

Comment on lines +34 to +35
<Route path="/privacy-policy" element={<PrivacyPolicy />} />
<Route path="/terms-conditions" element={<TermsConditions />} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new routes for the legal pages have an extra level of indentation compared to the other routes in this file. To maintain consistent code formatting and improve readability, please remove the extra indentation.

Suggested change
<Route path="/privacy-policy" element={<PrivacyPolicy />} />
<Route path="/terms-conditions" element={<TermsConditions />} />
<Route path="/privacy-policy" element={<PrivacyPolicy />} />
<Route path="/terms-conditions" element={<TermsConditions />} />

Contact Us
</h2>
<p className="text-gray-700 text-sm">
For questions about this policy, email us at support@localmind.dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The support email address is hardcoded. It's a good practice to define such values as constants in a separate configuration file (e.g., src/config/constants.ts) to improve maintainability and avoid magic strings. This makes it easier to update the email address across the application in the future.

Additionally, making the email a clickable mailto: link would improve user experience.

Suggested change
For questions about this policy, email us at support@localmind.dev
For questions about this policy, email us at <a href="mailto:support@localmind.dev" className="text-blue-600 hover:underline">support@localmind.dev</a>


{/* Social / Info */}
<div className="text-sm text-gray-300">
<p>Built with ❤️ by NexGenStudioDev</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The author name "NexGenStudioDev" is hardcoded. To improve maintainability, it's better to define this as a constant in a shared configuration or constants file. This allows for easier updates if the name changes.

Suggested change
<p>Built with ❤️ by NexGenStudioDev</p>
<p>Built with ❤️ by {'NexGenStudioDev'}</p>

@abhishek-nexgen-dev abhishek-nexgen-dev merged commit f300754 into NexGenStudioDev:master Jan 29, 2026
1 check passed
@ShivanshCoding36
Copy link
Contributor Author

Hi @abhishek-nexgen-dev
I didnt recieve any points for this
can you check why ECWoC26-REMOVED label is added
image
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants