Fix regression where output belt_to_ground entities are incorrectly placed backwards#112
Open
brandondahler wants to merge 1 commit intoNexela:masterfrom
Open
Fix regression where output belt_to_ground entities are incorrectly placed backwards#112brandondahler wants to merge 1 commit intoNexela:masterfrom
brandondahler wants to merge 1 commit intoNexela:masterfrom
Conversation
Owner
|
Thanks for this. Should be able to get to it in a couple of weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regression introduced in presumably 1.1 where belt_to_ground entities no longer respect direction updates.
Details
As of 1.1.36, belt_to_ground entities are always placed in the input direction, so we can plan accordingly to ensure that it faces the right way after rotation. See https://forums.factorio.com/99074 for specific issue details.
Testing
Verified manually in Sandbox scenario on 1.1.42.