Fix result modal working only on first table page#17
Open
MoshiMoshi0 wants to merge 3 commits intoNextdoor:masterfrom
Open
Fix result modal working only on first table page#17MoshiMoshi0 wants to merge 3 commits intoNextdoor:masterfrom
MoshiMoshi0 wants to merge 3 commits intoNextdoor:masterfrom
Conversation
Contributor
|
@swaggy could you merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using pagination, dataTables adds and removes <tr>'s from the DOM on every page change which causes new buttons to not have any 'click' callbacks.
The fix is to move the 'click' callback from each button to 'tbody' and use a selector instead.