Support more APScheduler job-types#59
Open
fake-name wants to merge 12 commits intoNextdoor:masterfrom
Open
Conversation
Holy potatoes jerberscript is MISERABLE. So much magic and action at a distance. Moar for Nextdoor#64
fake-name
changed the title
Author
|
Ok, it now also adds supports for:
|
…vely makes the code less readable.
# Conflicts: # ndscheduler/core/datastore/providers/postgresql.py # ndscheduler/corescheduler/datastore/base.py # ndscheduler/server/handlers/jobs.py
Author
|
Rolled up to current master. Any chance of this getting merged? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, right now, when you import ndscheduler, it installs it's own logging global handler.
If you're using ndscheduler in a context where you have existing logging infrastructure, this is extremely annoying, because it means you wind up either having to manually remove the logger after import, or you get double-logging of all log output.
Anyways, this PR just turns off the logging built-into the library. If you want logging, use
logging.basicConfig()or similar.In general, a library should never install a global logging handler on import.