feat: support hex representation for non-unicode strings #53
+234
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secDre4mer
force-pushed
the
feat/string-encoding
branch
from
472a2d7 to
929d2b2
Compare
secDre4mer
force-pushed
the
feat/string-encoding
branch
from
929d2b2 to
87cacf1
Compare
gremat
requested changes
Jan 27, 2026
| func (f MatchData) JSONSchemaAlias() any { | ||
| return "" | ||
| // Plaintext returns the raw byte sequence represented by the StringWithEncoding. | ||
| func (s StringWithEncoding) Plaintext() []byte { |
Contributor
There was a problem hiding this comment.
Given that one of the encoding types is plain, I don't know if this is a good choice for a name. What about Data or Raw?
| } | ||
| return data | ||
| default: | ||
| return []byte(fmt.Sprintf("<unknown encoding %s>", s.Encoding)) |
Contributor
There was a problem hiding this comment.
This return value is ambiguous because it could be held for a string with the same content. Thus this branch should rather end in an error state. On the other hand, we should never end up here.
I'd be fine with a comment stating that this shouldn't happen normally. But maybe we still want to include s.Data in the output in some way. (E.g., remove all invalid UTF8 chars but keep the message about unknown encoding?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.