Merged
Conversation
Replaced ~583 occurrences of NULL with nullptr in 51 C++ source files, following modern C++11 best practices for improved type safety. Changes: - Converted all NULL to nullptr in src/ directory (51 files) - Preserved NULL in public C API headers (include/lua.h, src/auxiliary/lauxlib.h) - Zero semantic changes - pure mechanical text replacement Performance: - Baseline: 4.20s average - After nullptr: 4.26s average (5 runs: 4.48, 4.21, 4.37, 4.09, 4.15) - Target: ≤4.33s (3% tolerance) - Status: ✅ PASS - within tolerance Testing: - All tests passing: "final OK !!!" - Zero compilation errors or warnings - Full backward compatibility maintained Benefits: - Type-safe null pointer constant (compile-time type checking) - Eliminates NULL macro ambiguity (0 vs pointer) - Modern C++11 standard practice - Better overload resolution - Zero performance impact
NiceAndPeter
deleted the
claude/modernize-nu-01WwycWxne9VSgahxUfqsWm1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced ~583 occurrences of NULL with nullptr in 51 C++ source files, following modern C++11 best practices for improved type safety.
Changes:
Performance:
Testing:
Benefits: