Merged
Conversation
Changes: - CMakeLists.txt: Add LUA_ENABLE_LTO option with safety flags - Uses -fno-strict-aliasing to handle type punning - Uses -ffat-lto-objects to reduce LTO aggressiveness - Default: OFF (LTO currently doesn't work) - GC code fixes for LTO: - gc_core.cpp: Handle VUPVAL, strings in getgclist() - gc_weak.cpp: Remove duplicate getgclist(), use GCCore version - Documentation: - docs/LTO_STATUS.md: Comprehensive LTO status report - Details issues found, root cause analysis, path forward Status: LTO exposes undefined behavior in the codebase - Corrupted type values (0xab) - Memory corruption in GC - Tests fail immediately with LTO enabled - Tests pass normally without LTO Recommendation: Do not enable LTO until UB is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
CMakeLists.txt: Add LUA_ENABLE_LTO option with safety flags
GC code fixes for LTO:
Documentation:
Status: LTO exposes undefined behavior in the codebase
Recommendation: Do not enable LTO until UB is fixed