#606 Implement v2 media endpoint

[Lastorder-DC]

https://docs.joinmastodon.org/methods/media/

It replaces v1 media endpoint with v2 media endpoint.

[NicolasConstant]

Thanks for contributing to Sengi!

Unfortunately we can't remove v1 support: since other software (like Pleroma) might rely on it, we could call v1 or v2 depending on the software/version used, a bit like how it's done in the search API call wrapping.

[Lastorder-DC]

Okay. will change code to implement both v1 and v2.

[Lastorder-DC]

Can I implement v1 as a fallback? since v2 is more reliable than v1(if supported), and both mastodon compatible sw I know(pleroma and its fork akkoma) supports v2 media endpoint.

(edit)
You can edit this PR to what you want. I can start working on this after 8/18

[NicolasConstant]

Take all the time you need. 🙂

Instead of a fallback (that would mean calling twice in the worth case) I would rather analyses the instance's version and call the appropriate version. For example the search api is called after this analysis was done;

sengi/src/app/components/create-status/autosuggest/autosuggest.component.ts

Lines 68 to 74 in c3cd6fe

	this.toolsService.getInstanceInfo(selectedAccount)
	.then(instance => {
	let version: 'v1' | 'v2' = 'v1';
	if(instance.major >= 3) version = 'v2';
	return this.mastodonService.search(selectedAccount, pattern, version, false);
	})
	.then((results: Results) => {

I would reuse a similar pattern before calling the new media implementation.

(Of course, if we migrate more and more v2 implementation, that would be useful to regroup this particular logic in a dedicated layer, but lest keep things as they are for now)