feat: adding general shuffle example for any vector size#76
Open
feat: adding general shuffle example for any vector size#76
Conversation
jimouris
approved these changes
Oct 22, 2024
jcabrero
reviewed
Oct 23, 2024
Member
jcabrero
left a comment
There was a problem hiding this comment.
The code looks good to me 👍 . Just one small comment, in tests/test_all.py, add this example to the list EXAMPLES. In that way, we test all examples with the CI and ensure they all work with the latest version.
jcabrero
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a preliminary example for shuffling a vector without any constraint in size. We want to greatly improve on this but we can have it as an example for reference before we include it under nada-numpy.
Note: The example does not support arrays with
RationalorSecretRationaltypes.Optimizations for future reference:
one_hot_vectoras a preprocessing element from nada dsl.