Draft
Conversation
Rather than re-implementing the legacy SSH store protocol, we now use Store directly. To be able to support build cancellation, the actual build is performed by a helper process (hydra-build-step), which can be killed by hydra-queue-runner if the corresponding step is cancelled.
Member
|
Pushed |
13 tasks
Member
|
The conflicts between the build remote split PR (now merged into master) and this are fixed. As expected, this PR obviates most of the split out functions by instead moving functionality to the new executable, so the split out functions are mostly just deleted and the diff is fairly small. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the duplicate implementation of the
nix-store --serveclient inbuildRemote(). Instead we now use theStoreAPI directly. To be able to support build cancellation, the actual build is performed by a helper process (hydra-build-step), which can be killed byhydra-queue-runnerif the corresponding step is cancelled.To do:
ssConnecting.Machineduplication between Hydra and libstore.RemoteResultandBuildResult.