Skip to content

Comments

tandoor-recipes: init at 1.4.1#191532

Merged
SuperSandro2000 merged 23 commits intoNixOS:masterfrom
ambroisie:add-tandoor-recipes
Oct 3, 2022
Merged

tandoor-recipes: init at 1.4.1#191532
SuperSandro2000 merged 23 commits intoNixOS:masterfrom
ambroisie:add-tandoor-recipes

Conversation

@ambroisie
Copy link
Contributor

@ambroisie ambroisie commented Sep 16, 2022 •
edited
Loading

Description of changes

Closes #145244.

A whole lot of python packages that were added to get this working. django-autocomplete-light has been marked doCheck = false to avoid having to package half a dozen more just for its tests.

The frontend does not make use of mkYarnPackage, because of the following issue.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 16, 2022
ambroisie
ambroisie commented Sep 16, 2022
View reviewed changes
ambroisie
ambroisie commented Sep 16, 2022
View reviewed changes
pkgs/applications/misc/tandoor-recipes/default.nix Outdated
Copy link
Contributor Author

@ambroisie ambroisie Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ierror/django-js-reverse#114 for when this isn't needed anymore.

ambroisie
ambroisie commented Sep 16, 2022
View reviewed changes
@ambroisie ambroisie force-pushed the add-tandoor-recipes branch 4 times, most recently from 4d6bb88 to f3ce4f3 Compare September 16, 2022 18:07
ambroisie
ambroisie commented Sep 16, 2022
View reviewed changes
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 16, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 16, 2022
@ambroisie ambroisie force-pushed the add-tandoor-recipes branch 2 times, most recently from e90189a to 788d704 Compare September 17, 2022 15:48
@nixos-discourse
Copy link

nixos-discourse commented Sep 17, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1196

SuperSandro2000
SuperSandro2000 reviewed Sep 17, 2022
View reviewed changes
@ambroisie ambroisie force-pushed the add-tandoor-recipes branch 4 times, most recently from 963107b to 08eb42f Compare September 17, 2022 19:39
@ambroisie
Copy link
Contributor Author

ambroisie commented Sep 17, 2022 •
edited
Loading

@SuperSandro2000 addressed all your comments.

@ambroisie ambroisie force-pushed the add-tandoor-recipes branch 2 times, most recently from c0df50e to a95227f Compare September 17, 2022 20:18
@ambroisie
python310Packages.django-hcaptcha: init at 0.2.0
5c71b23
@ambroisie
python310Packages.django-crispy-forms: init at 1.14.0
1c6d12b
@ambroisie
python310Packages.django-js-reverse: init at 2022-09-16
20c95ad
@ambroisie
python310Packages.django-scopes: init at 1.2.0.post1
cdb9918
@ambroisie
python310Packages.bleach-allowlist: init at 1.0.3
682ebaa
@ambroisie
python310Packages.jstyleson: init at 2022-09-16
6505d75
@ambroisie
python310Packages.microdata: init at 0.8.0
b0f1f71
@ambroisie
python310Packages.html-text: init at 0.5.2
f0b2aba
@ambroisie
python310Packages.mf2py: init at 1.1.2
ac7c585
@ambroisie
python310Packages.pyrdfa3: init at 3.5.3
8c3ae39
@ambroisie
python310Packages.extruct: init at 0.13.0
48919bc
@ambroisie
python310Packages.language-tags: init at 1.1.0
d1710a2
@ambroisie
python310Packages.recipe-scrapers: init at 14.14.0
c9185db
@ambroisie
python310Packages.drf-writable-nested: init at 0.6.4
81ab6b5
@ambroisie
python310Packages.django-cors-headers: 3.7.0 -> 3.13.0
f2a7a77
@ambroisie
python310Packages.django-oauth-toolkit: relax 'django' dependency
334ca79
@ambroisie
python310Packages.djangorestframework: fix 'collectstatic' with djang…
284e894 
…o 4.1
@ambroisie ambroisie force-pushed the add-tandoor-recipes branch 3 times, most recently from 950560f to 25d511d Compare September 29, 2022 16:27
SuperSandro2000
SuperSandro2000 approved these changes Oct 1, 2022
View reviewed changes
@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 1, 2022
@ambroisie ambroisie force-pushed the add-tandoor-recipes branch from 25d511d to 83f5c2d Compare October 3, 2022 07:49
@ofborg ofborg bot requested a review from SuperSandro2000 October 3, 2022 07:58
@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 3, 2022
@SuperSandro2000 SuperSandro2000 merged commit 1385382 into NixOS:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NobbZ NobbZ NobbZ left review comments

@mweinelt mweinelt mweinelt requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@desiderius desiderius Awaiting requested review from desiderius

@mmai mmai Awaiting requested review from mmai

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

+1 more reviewer

@vabene1111 vabene1111 vabene1111 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

package/module request: tandoor recipes

7 participants

@ambroisie @nixos-discourse @NobbZ @SuperSandro2000 @mweinelt @vabene1111 @bobby285271