vcv-rack: 2.6.0 -> 2.6.6; add darwin support; modernize

[afh]

Description of changes

☝️ This PR contains and builds on the changes proposed in #306692

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[afh]

Result of nixpkgs-review pr 332358 run on x86_64-linux 1

1 package built:

• vcv-rack

[afh]

Kindly requesting review from @NixOS/darwin-maintainers

[matteo-pacini]

@afh The app executable is not in the Contents/MacOS folder when compiling on aarch64-darwin 🤔

[afh]

Huh, that's odd, for Rack 2.5.1 the Rack executable was being built. I'll remove the update to 2.5.2 for now then to be able to move forward here.

[afh]

Mind giving this another go, @matteo-pacini?

[afh]

Result of nixpkgs-review pr 332358 run on x86_64-darwin 1

1 package built:

• vcv-rack

[matteo-pacini]

@afh Seems to be built without errors like before, but the executable is still missing (?).

For context, ran nix run "nixpkgs#nixpkgs-review" -- pr --print-result 332358 twice on aarch64-darwin, if anyone from @NixOS/darwin-maintainers wants to give this a go.

[afh]

Thanks, @matteo-pacini, I'm converting this to a draft and will have a closer look at what is going on…

[FlameFlag]

@afh @matteo-pacini I was able to build on aarch64-darwin without any issues?

[nix-shell:~/.cache/nixpkgs-review/pr-332358]$ cat report.md
Result of `nixpkgs-review pr 332358` run on aarch64-darwin [1](https://github.com/Mic92/nixpkgs-review)
<details>
  <summary>1 package built:</summary>
  <ul>
    <li>vcv-rack</li>
  </ul>
</details>

[matteo-pacini]

@DontEatOreo can you see the executable inside the app bundle/Contents/MacOS?

Builds fine for me too, but the executable is missing

[FlameFlag]

Ahh, I think I misunderstood the problem earlier, sadly no executable /Contents/MacOS for me either

[Detegr]

I have the same issue of font rendering not working with this version.

[afh]

Now that Rack 2.6.6 has been released and this PR updated, would folks be so kind and help out with testing again?

/cc @Detegr, @FlameFlag, @jpotier, @matteo-pacini, @siraben

[afh]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 332358
Commit: 38a486e6856fe33f988de0b26cf82e52c126b1c3

---

x86_64-linux

✅ 1 package built:

• vcv-rack

---

aarch64-linux

✅ 1 package built:

• vcv-rack

[dwt]

Builds and works fine on Darwin. Tested with the provided tutorial patch.

---

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 332358
Commit: 38a486e6856fe33f988de0b26cf82e52c126b1c3

---

aarch64-darwin

✅ 1 package built:

• vcv-rack

[Detegr]

Built on Linux 6.17.6, Wayland with Sway. Still has the #393113 issue and the font rendering is broken.

[GaetanLepage]

LGTM overall, thanks!
Please squash your commits. I think that having a single vcv-rack: 2.6.0 -> 2.6.6 would be fine.
If you prefer, you could also have three (cleanup, add darwin support and update).
But 11 is a bit too many for this patch.

[liberodark]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 332358
Commit: 38a486e6856fe33f988de0b26cf82e52c126b1c3 (subsequent changes)
Merge: 16035a9f41b8925d8d6f50aaa3deed9ef097717e

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/19193033272

---

x86_64-linux

✅ 1 package built:

• vcv-rack

---

aarch64-linux

✅ 1 package built:

• vcv-rack

---

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:

• vcv-rack

---

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:

• vcv-rack

[Detegr]

To fix the #393113 issue, could you add this patch in:

diff --git a/pkgs/by-name/vc/vcv-rack/package.nix b/pkgs/by-name/vc/vcv-rack/package.nix
index eef5914b6510..1b5cec3918a2 100644
--- a/pkgs/by-name/vc/vcv-rack/package.nix
+++ b/pkgs/by-name/vc/vcv-rack/package.nix
@@ -208,6 +208,10 @@ stdenv.mkDerivation (finalAttrs: {
     # For some unknown reason __yield isn't available on aarch64-linux
     substituteInPlace src/engine/Engine.cpp \
       --replace-fail '__yield();' 'asm volatile("yield");'
+
+    # Patch in GLFW init hint to make initialization work correctly on Wayland
+    substituteInPlace src/window/Window.cpp \
+      --replace-fail '// Set up GLFW' 'glfwInitHint(GLFW_PLATFORM, GLFW_PLATFORM_X11);'
   ''
   + lib.optionalString stdenv.hostPlatform.isDarwin ''
     # * Set VERSION from finalAttrs to avoid build using git to determine version

This has also been proposed upstream but they don't accept pull requests so I think we need to patch it until they do work on Wayland support.

[afh]

@GaetanLepage your suggestions have been applied to this PR.

@Detegr thanks for diving into this, the mentioned patch is now applied when building for/on Linux.

[GaetanLepage]

Formatting issue apparently.
Also, there is a typo in the first commit: lib.optional instead of lib.optionals.

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 332358
Commit: 526f5a1c0c9a8c71be3924bbec2dd7aced355f63

---

x86_64-linux

✅ 1 package built:

• vcv-rack

---

aarch64-linux

✅ 1 package built:

• vcv-rack

---

x86_64-darwin

✅ 1 package built:

• vcv-rack

---

aarch64-darwin

✅ 1 package built:

• vcv-rack

[afh]

Thanks everyone for helping out and getting this merged! 🙏

[doronbehar]

There is an evaluation error on staging-next:

error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "apple-sdk_13" at /nix/store/0w1ia83mgkcqdzaj1g864xiqzflghmi9-source/pkgs/by-name/vc/vcv-rack/package.nix:3, did you mean "apple-sdk_14", "apple-sdk_15" or "apple-sdk_26"?'

Can anyone confirm somehow this issue won't exist once master is merged into staging-next?