Skip to content

Revert "nodejs_22: use shared SQLite"#366362

Closed
aduh95 wants to merge 1 commit intoNixOS:staging-nextfrom
aduh95:revert-shared-sqlite
Closed

Revert "nodejs_22: use shared SQLite"#366362
aduh95 wants to merge 1 commit intoNixOS:staging-nextfrom
aduh95:revert-shared-sqlite

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 18, 2024

This reverts commit 5ec3e7b.

Opening a PR targeting staging-next because of #361565 (review).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 18, 2024
@vcunat
Copy link
Member

vcunat commented Dec 19, 2024

Because of what? nodejs_22 seems to build now on staging-next:
https://hydra.nixos.org/eval/1810541?filter=nodejs_22&compare=trunk

(and this PR is marked as quite a big rebuild)

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 19, 2024

My bad, I misinterpreted the linked comment, I thought it was saying it wasn't building without it

@aduh95 aduh95 closed this Dec 19, 2024
@aduh95 aduh95 deleted the revert-shared-sqlite branch December 19, 2024 09:07
@vcunat
Copy link
Member

vcunat commented Dec 19, 2024

OK. Good to clear that up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants