Skip to content

Conversation

@usertam
Copy link
Member

@usertam usertam commented Mar 16, 2025

  • poselib is a new dependency of colmap.
  • one colmap third-party dep fails to build with new clang, brought in a patch
  • colmap can now be built with clang, so platforms.linux -> platforms.unix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 16, 2025
@nix-owners nix-owners bot requested a review from lebastr March 16, 2025 15:35
@usertam
Copy link
Member Author

usertam commented Mar 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review --extra-nixpkgs-config '{ permittedInsecurePackages = [ "freeimage-unstable-2021-11-01" ]; }'


x86_64-linux

✅ 3 packages built:
  • colmap
  • colmapWithCuda
  • poselib

aarch64-linux

✅ 3 packages built:
  • colmap
  • colmapWithCuda
  • poselib

x86_64-darwin

❌ 1 package failed to build:
  • colmap
✅ 1 package built:
  • poselib

aarch64-darwin

✅ 2 packages built:
  • colmap
  • poselib

freeimage error on x86_64-darwin because of lack of header pad

Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
/nix/store/c02v2y65yvrb769i87pfngq4r5l22b22-freeimage-unstable-2021-11-01/lib/libfreeimage-3.19.0.dylib: fixing dylib
error: install_name_tool: changing install names or rpaths can't be redone for: /nix/store/c02v2y65yvrb769i87pfngq4r5l22b22-freeimage-unstable-2021-11-01/lib/libfreeimage-3.19.0.dylib (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 16, 2025
@nix-owners nix-owners bot requested a review from L-as March 16, 2025 17:41
@usertam
Copy link
Member Author

usertam commented Mar 16, 2025

I touched freeimage to fix that so now it can build.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review --extra-nixpkgs-config '{ permittedInsecurePackages = [ "freeimage-unstable-2021-11-01" ]; }'

x86_64-darwin

❌ 2 packages failed to build:
  • sbclPackages.cl-freeimage
  • sbclPackages.clinch-freeimage
✅ 5 packages built:
  • colmap
  • freeimage
  • gamecube-tools
  • perceptualdiff
  • poselib

aarch64-darwin

❌ 2 packages failed to build:
  • sbclPackages.cl-freeimage
  • sbclPackages.clinch-freeimage
✅ 5 packages built:
  • colmap
  • freeimage
  • gamecube-tools
  • perceptualdiff
  • poselib

x86_64-linux

❌ 5 packages failed to build:
  • arrayfire
  • cudaPackages_11.cuda-samples
  • emulationstation-de
  • forge
  • trenchbroom
✅ 15 packages built:
  • colmap
  • colmapWithCuda
  • emulationstation
  • freeimage
  • gamecube-tools
  • kew
  • perceptualdiff
  • pgf_graphics
  • poselib
  • posterazor
  • rucksack
  • sbclPackages.cl-freeimage
  • sbclPackages.clinch-freeimage
  • slade
  • sladeUnstable

aarch64-linux

❌ 3 packages failed to build:
  • arrayfire
  • emulationstation-de
  • forge
✅ 14 packages built:
  • colmap
  • colmapWithCuda
  • emulationstation
  • freeimage
  • gamecube-tools
  • kew
  • perceptualdiff
  • pgf_graphics
  • poselib
  • posterazor
  • sbclPackages.cl-freeimage
  • sbclPackages.clinch-freeimage
  • slade
  • sladeUnstable

@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 21, 2025
@usertam
Copy link
Member Author

usertam commented Mar 22, 2025

Rebased since the freeimage PR #369766 is merged. All OK?

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review --extra-nixpkgs-config '{ permittedInsecurePackages = [ "freeimage-3.18.0-unstable-2024-04-18" ]; }'


x86_64-linux

✅ 3 packages built:
  • colmap
  • colmapWithCuda
  • poselib

aarch64-linux

✅ 3 packages built:
  • colmap
  • colmapWithCuda
  • poselib

x86_64-darwin

✅ 2 packages built:
  • colmap
  • poselib

aarch64-darwin

✅ 2 packages built:
  • colmap
  • poselib

@usertam usertam requested a review from L-as March 25, 2025 16:36
@usertam
Copy link
Member Author

usertam commented Mar 31, 2025

Bump, ready for merge.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@wilhelmines
Copy link
Member

wilhelmines commented Aug 19, 2025

Hey, is there a way to revive this pr? It seems to address most of the problems so redoing everything based the current colmap nixpkgs version would be a waste of time. I'm not sure where the merge conflict appeared, but I would like to help getting this done.

@usertam
Copy link
Member Author

usertam commented Jan 6, 2026

Superseded by #438672. Thank you @chpatrick for picking this up!

@usertam usertam closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants