haskell.compiler.ghc{924,963,984}Binary: use broken for NCG check#441069
haskell.compiler.ghc{924,963,984}Binary: use broken for NCG check#441069emilazy merged 1 commit intoNixOS:masterfrom
broken for NCG check#441069Conversation
Fix availability checks on platforms where this would be false.
|
Wonder if it’d be good to have an advisory CI eval check for some platform that we don’t fully support but that you could reasonably expect to at least have working eval (e.g. one of i686, ARMv7, RISC‐V, LoongArch64). |
wegank
left a comment
There was a problem hiding this comment.
LGTM.
Anecdote: In loongson-community@0d111ea, @darkyzhou added LoongArch support for GHC 9.8 by bootstrapping from Debian binaries (while LoongArch only has NCG backend support in 9.14+). I assume we'll remove the broken condition downstream during the next loong-testing branch rebase, but it's been a while since the last rebase, anyway.
|
Looks like my work in #440774 should help a lot with that; funny that someone else was already backporting LLVM support patches to GHC. Interesting to hear that the Debian binary package works. Maybe @sternenseemann talking about other distros’ binaries not working is out of date. Not sure whether that’s more or less nice than the cross‐built GHC 9.4.8 bootstrap plan, but it’s at least fewer moving parts. I do wonder how Debian produced those binaries in the first place. I don’t think the It would be cool to see some of this stuff upstreamed, especially if we wire up the “chain everything back to GHC 9.4.8” plan. |
Fix availability checks on platforms where this would be false.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.