Skip to content

Comments

haskell.compiler.ghc{924,963,984}Binary: use broken for NCG check#441069

Merged
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-looqymqtlwsk
Sep 8, 2025
Merged

haskell.compiler.ghc{924,963,984}Binary: use broken for NCG check#441069
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-looqymqtlwsk

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Sep 7, 2025

Fix availability checks on platforms where this would be false.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Fix availability checks on platforms where this would be false.
@emilazy
Copy link
Member Author

emilazy commented Sep 7, 2025

Wonder if it’d be good to have an advisory CI eval check for some platform that we don’t fully support but that you could reasonably expect to at least have working eval (e.g. one of i686, ARMv7, RISC‐V, LoongArch64).

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Sep 7, 2025
Copy link
Member

@wegank wegank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Anecdote: In loongson-community@0d111ea, @darkyzhou added LoongArch support for GHC 9.8 by bootstrapping from Debian binaries (while LoongArch only has NCG backend support in 9.14+). I assume we'll remove the broken condition downstream during the next loong-testing branch rebase, but it's been a while since the last rebase, anyway.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 8, 2025
@emilazy
Copy link
Member Author

emilazy commented Sep 8, 2025

Looks like my work in #440774 should help a lot with that; funny that someone else was already backporting LLVM support patches to GHC.

Interesting to hear that the Debian binary package works. Maybe @sternenseemann talking about other distros’ binaries not working is out of date. Not sure whether that’s more or less nice than the cross‐built GHC 9.4.8 bootstrap plan, but it’s at least fewer moving parts. I do wonder how Debian produced those binaries in the first place.

I don’t think the broken condition will need adjusting once #440774 lands, since ghc966LoongArch64Binary will be a separate package. Actually, it should simplify things, since most of the GHC patches will already be incorporated by my PR.

It would be cool to see some of this stuff upstreamed, especially if we wire up the “chain everything back to GHC 9.4.8” plan.

@emilazy emilazy merged commit 892ee02 into NixOS:master Sep 8, 2025
32 of 35 checks passed
@emilazy emilazy deleted the push-looqymqtlwsk branch September 8, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants