Change bindgen to optional and keep the old method as default #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@lucascompython, we hope to maintain the previous approach of creating ffi.rs. do you encountered any problems in this way? |
Contributor
|
No, I didn't encounter any problems, I just found it easier to build with the bindgen method since that way I didn't have to install any external tools. |
Contributor
|
This pull request caused build failures on 32-bit systems, including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change bindgen to optional and keep the old method as the default to reduce complexity.
Executing bindgen in build.rs helps ensure correct cross-compilation, but it increases maintenance complexity. Before encountering any issues, it is preferable to keep things simple.
@Brooooooklyn