Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to extract hidden nodes when the -includeHidden command-line flag is specified, bumping the version from 1.15.0 to 1.16.0.
- Adds a new
-includeHiddencommand-line argument to include nodes marked as hidden in the extension point - Updates the
NodeDoc.hiddenfield from deprecated to undeprecated (since v1.16) - Version bump across all Maven and OSGi manifest files from 1.15.0 to 1.16.0
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java | Implements the core functionality for extracting and processing hidden nodes with new flag and helper method |
| application/src/de/philippkatz/knime/jsondocgen/docs/NodeDoc.java | Updates documentation comment for the hidden field to reflect it is no longer deprecated |
| application/pom.xml | Version bump to 1.16.0-SNAPSHOT |
| application/META-INF/MANIFEST.MF | Version bump to 1.16.0.qualifier |
| tests/pom.xml | Version bump to 1.16.0-SNAPSHOT with updated parent and bundle versions |
| tests/META-INF/MANIFEST.MF | Version bump to 1.16.0.qualifier with updated Fragment-Host |
| feature/pom.xml | Version bump to 1.16.0-SNAPSHOT |
| feature/feature.xml | Version bump to 1.16.0.qualifier |
| p2/pom.xml | Version bump to 1.16.0-SNAPSHOT |
| pom.xml | Version bump to 1.16.0-SNAPSHOT in root and target platform artifact |
| targetplatform/pom.xml | Version bump to 1.16.0-SNAPSHOT |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java
Outdated
Show resolved
Hide resolved
application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java
Outdated
Show resolved
Hide resolved
qqilihq
commented
Nov 10, 2025
application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally extract nodes which are marked as “hidden” if
-includeHiddenis set.