Open
Conversation
…rt all other changes to match main
shannonsands
force-pushed
the
textarena-minimal
branch
from
47e0a6f to
ff0a0bc
Compare
dmahan93
requested changes
Aug 12, 2025
| f"[Traj {trajectory_idx}] Step {step_count} | Player {current_player} | Obs: {_obs_preview}..." | ||
| ) | ||
|
|
||
| if current_player == self.config.training_player_index: |
Collaborator
There was a problem hiding this comment.
if it's multiplayer and the other players are the same policy why are we throwing them away
Contributor
Author
There was a problem hiding this comment.
because I didn't want to overcomplicate things with this PR basically. We'd need to do group rollouts with all players & build their own ScoredDataGroups
Collaborator
There was a problem hiding this comment.
we're basically doing that already minus building independent ScoredDataGroups
Contributor
Author
There was a problem hiding this comment.
Ok, can add it. But the other players trajectories won't all be starting from the same state (since player 1's moves can be totally different), so not sure how meaningful the advantage calculation for them will be
shannonsands
force-pushed
the
textarena-minimal
branch
from
f8a560e to
02ef607
Compare
for more information, see https://pre-commit.ci
dmahan93
requested changes
Aug 25, 2025
| f"[Traj {trajectory_idx}] Step {step_count} | Player {current_player} | Obs: {_obs_preview}..." | ||
| ) | ||
|
|
||
| if current_player == self.config.training_player_index: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
📝 General Information
Description
Integration & registry code for TextArena. Random sampling over all TextArena games. Minimal agent implementation, just parallel rollouts with max steps. Single agent trainer only, no full self play yet (opponents don't train)
🔖 Environment Snapshot
🧪 Zero-Training Test Results
Details
W&B Link:
https://wandb.ai/nous_research/hermes-qwen3-14b-grpo-textarena/runs/myzy6tx0
Examples of the Environment scoring a good example and a bad example:
✅ Developer & Reviewer Checklist