-
-
Notifications
You must be signed in to change notification settings - Fork 8
[16.0] [ADD] website_slides_attendees_completed_time: show completed time in attendee views #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [ADD] website_slides_attendees_completed_time: show completed time in attendee views #10
Conversation
4d162c4 to
25b79fd
Compare
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I explained myself properly. Thanks
website_slides_attendees_completed_time/models/slide_channel_partner.py
Outdated
Show resolved
Hide resolved
website_slides_attendees_completed_time/models/slide_slide_partner.py
Outdated
Show resolved
Hide resolved
25b79fd to
622b1ec
Compare
…me tracking in attendee views [IMP] website_slides_attendees_completed_time: compute attendee completed time through built-in recompute_completion feature [IMP] website_slides_attendees_completed_time: enhance DESCRIPTION; implement tests for completed time
622b1ec to
c5bd082
Compare
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional and code review, LGTM
✅ Update on the Approach TakenHello @Christian-RB and community, After careful consideration, we’ve decided to align with the native 🔄 What ChangedThe key update alongside this decision is that the field To ensure this, we’ve implemented a 🧪 Tests IncludedWe’ve also added a suite of unit tests. These were designed following the pattern of the native tests for the It’s important to highlight that although the
This means that updates to
We believe this dual-tracking (count-based + time-based) gives a more robust and insightful representation of learner engagement. We’re now just awaiting the community’s feedback. Thanks for reviewing! |
|
@rrebollo Can you add the version [16.0] in the PR title? Thanks |
edescalona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This PR has the |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
|
Hi @rrebollo is this necessary when a progress field already exists? |
|
@jelenapoblet we anticipate this concern. From a comment above 👉:
And from the addon's documentation:
|
|
ping @jelenapoblet comment |
|
@rrebollo are you also going to maintain this ? is there a plan to migrate this module to v17, 18 and 19 ? |
Yes and yes |
|
/ocabot merge nobump |
|
Sorry @jelenapoblet you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 5bb17db. Thanks a lot for contributing to OCA. ❤️ |

This module extends the functionality of course attendee views to show course's completed time.
After module installation, you will see course's completed time within attendee views.
@BinhexTeam