Skip to content

Conversation

@sybdeb
Copy link

@sybdeb sybdeb commented Dec 22, 2025

Description

Migration of helpdesk_mgmt module from 18.0 to 19.0.

This migration addresses the following Odoo 19.0 framework changes:

Mail Threading API Updates

  • Updated _message_get_suggested_recipients() to accept flexible parameters using **kwargs for compatibility with Odoo 19's varying parameter requirements
  • Updated _notify_get_reply_to() to include new author_id parameter
  • Changed _message_add_suggested_recipient() to _message_add_suggested_recipients() (plural) with updated signature using email parameter instead of partner

Field Requirements

  • Changed name and description fields from required=True to required=False to support ticket creation via email (subject line populates these fields)

OCA Compliance

  • Version bumped to 19.0.1.0.0
  • Removed migrations folder as per OCA guidelines
  • Pre-commit checks passed

Testing

  • Module tested in production environment
  • All ticket creation workflows verified (portal, email, backend)
  • Mail threading and notifications working correctly

Related Issues

Closes #xxx (if applicable - replace with actual issue number)

oca-ci and others added 30 commits August 21, 2025 06:53
Signed-off-by marcelsavegnago
Currently translated at 5.2% (14 of 268 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv/
Currently translated at 0.3% (1 of 268 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv_LV/
Currently translated at 13.0% (35 of 268 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv/
That's way, the portal User can use the "New" button in the tile but also in the header if User choose to browse existing tickets

Fixing Issue OCA#820
Signed-off-by pedrobaeza
Currently translated at 100.0% (7 of 7 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_fieldservice_equipment
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_fieldservice_equipment/it/
Signed-off-by marcelsavegnago
Currently translated at 100.0% (4 of 4 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_fieldservice_equipment_warranty
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_fieldservice_equipment_warranty/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/es_AR/
Currently translated at 100.0% (5 of 5 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/pt/
Currently translated at 100.0% (5 of 5 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/es/
eduezerouali-tecnativa and others added 18 commits December 4, 2025 18:15
Signed-off-by pedrobaeza
Currently translated at 100.0% (295 of 295 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/it/
Signed-off-by pedrobaeza
Add copy=False to assigned_date and closed_date fields
Currently translated at 17.6% (52 of 295 strings)

Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv/
Signed-off-by marcelsavegnago
Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Signed-off-by rvalyi
@sybdeb sybdeb changed the title 19.0 mig helpdesk mgmt [19.0][MIG] helpdesk_mgmt: Migration to 19.0 Dec 22, 2025
@pedrobaeza
Copy link
Member

Please check CI.

@sybdeb sybdeb marked this pull request as draft January 3, 2026 11:45
@sybdeb sybdeb marked this pull request as ready for review January 3, 2026 11:49
@sybdeb
Copy link
Author

sybdeb commented Jan 3, 2026

This PR migrates helpdesk_mgmt to Odoo 19.0.

Main changes:

  • Removed post_init_hook (groups_id field removed in 19.0)
  • Adapted portal closing to Odoo 19 core behavior (single close button, folded stages)
  • Fixed various API changes (mail threading, fields, JS imports, etc.)
  • All tests pass, pre-commit green
  • Tested in production-like environment: ticket creation, portal, fetchmail all working

Ready for review and merge! 🚀

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sybdeb thanks for the work. however your PR has currently a big issue: it has many migration commits. Apparently this is done by AI. This is not the problem, the problem is the number of migration commits. Indeed, because of the standard OCA migration process, when we review migration PRs, we review the migration commits individually. But this is only possible if a migration is done in 1 to 3 or 4 commits (unless it's a very complex module which is not the case here).

So what you should do is use the command rebase 19.0 -i to squash these numerous migration commits into just one or may be 5 max eventually.

Before doing the rebase you can save your branch with the detailed commits with git branch 19.0-mig-helpdesk_mgmt-backup eventually

Once the squash is done push the branch again with the --force option.

- Update version from 18.0 to 19.0
- Fix _read_group compatibility (Odoo 19 API changes)
- Fix message_post and mail methods compatibility
- Update portal access and close button functionality
- Fix hooks.py: remove groups_id field handling (field removed in Odoo 19)
- Update JavaScript imports and dashboard
- Apply pre-commit formatting and fixes
- Update GitHub workflows and CI configuration
@sybdeb sybdeb closed this Jan 3, 2026
@sybdeb sybdeb force-pushed the 19.0-mig-helpdesk_mgmt branch from 61792c3 to d4fb768 Compare January 3, 2026 19:51
@rvalyi rvalyi self-requested a review January 3, 2026 20:22
@rvalyi
Copy link
Member

rvalyi commented Jan 3, 2026

Thanks for the squash however there are still many issues: please check the changes and added files outside of the helpdesk_mgmt folder: they should not exist. If for some reason you need to update the dotfiles of the repo with the newest OCA standard, do it using the copier tool in a separate PR. Obviously many files have been added while they should not. Also check the changes/deletion in the other modules, there should be no such changes.

Check hook.py, it seems this file should not be added if it does nothing.

Also please take some time to learn from accepted migration PRs, possibly from other PRs before submitting PRs in the OCA, so it doesn't drain the energy from the reviewers when you are still in the learning phase.

@sybdeb
Copy link
Author

sybdeb commented Jan 3, 2026

@sybdeb thanks for the work. however your PR has currently a big issue: it has many migration commits. Apparently this is done by AI. This is not the problem, the problem is the number of migration commits. Indeed, because of the standard OCA migration process, when we review migration PRs, we review the migration commits individually. But this is only possible if a migration is done in 1 to 3 or 4 commits (unless it's a very complex module which is not the case here).

So what you should do is use the command rebase 19.0 -i to squash these numerous migration commits into just one or may be 5 max eventually.

Before doing the rebase you can save your branch with the detailed commits with git branch 19.0-mig-helpdesk_mgmt-backup eventually

Once the squash is done push the branch again with the --force option.

@rvalyi i unfortunatley only do not know how to get it merged now but it should be squashed.
the porting was don with co-pilot indeed, i need helpdesk in 19 to go and use my almost ready dropshipment webshop addons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.