-
-
Notifications
You must be signed in to change notification settings - Fork 405
[19.0][MIG] helpdesk_mgmt: Migration to 19.0 #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently translated at 5.2% (14 of 268 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv/
Currently translated at 0.3% (1 of 268 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv_LV/
Currently translated at 13.0% (35 of 268 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv/
That's way, the portal User can use the "New" button in the tile but also in the header if User choose to browse existing tickets Fixing Issue OCA#820
Currently translated at 100.0% (7 of 7 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_fieldservice_equipment Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_fieldservice_equipment/it/
Currently translated at 100.0% (4 of 4 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt_fieldservice_equipment_warranty Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt_fieldservice_equipment_warranty/it/
Currently translated at 100.0% (5 of 5 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/it/
Currently translated at 100.0% (5 of 5 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/es_AR/
Currently translated at 100.0% (5 of 5 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/pt/
Currently translated at 100.0% (5 of 5 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_type_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_type_sla/es/
Currently translated at 100.0% (295 of 295 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/it/
Since OCA/field-service@21b64d83, `resolution` is now an Html field.
Add copy=False to assigned_date and closed_date fields
Currently translated at 17.6% (52 of 295 strings) Translation: helpdesk-18.0/helpdesk-18.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-18-0/helpdesk-18-0-helpdesk_mgmt/lv/
Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
|
Please check CI. |
|
This PR migrates helpdesk_mgmt to Odoo 19.0. Main changes:
Ready for review and merge! 🚀 |
rvalyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sybdeb thanks for the work. however your PR has currently a big issue: it has many migration commits. Apparently this is done by AI. This is not the problem, the problem is the number of migration commits. Indeed, because of the standard OCA migration process, when we review migration PRs, we review the migration commits individually. But this is only possible if a migration is done in 1 to 3 or 4 commits (unless it's a very complex module which is not the case here).
So what you should do is use the command rebase 19.0 -i to squash these numerous migration commits into just one or may be 5 max eventually.
Before doing the rebase you can save your branch with the detailed commits with git branch 19.0-mig-helpdesk_mgmt-backup eventually
Once the squash is done push the branch again with the --force option.
- Update version from 18.0 to 19.0 - Fix _read_group compatibility (Odoo 19 API changes) - Fix message_post and mail methods compatibility - Update portal access and close button functionality - Fix hooks.py: remove groups_id field handling (field removed in Odoo 19) - Update JavaScript imports and dashboard - Apply pre-commit formatting and fixes - Update GitHub workflows and CI configuration
61792c3 to
d4fb768
Compare
|
Thanks for the squash however there are still many issues: please check the changes and added files outside of the helpdesk_mgmt folder: they should not exist. If for some reason you need to update the dotfiles of the repo with the newest OCA standard, do it using the copier tool in a separate PR. Obviously many files have been added while they should not. Also check the changes/deletion in the other modules, there should be no such changes. Check hook.py, it seems this file should not be added if it does nothing. Also please take some time to learn from accepted migration PRs, possibly from other PRs before submitting PRs in the OCA, so it doesn't drain the energy from the reviewers when you are still in the learning phase. |
@rvalyi i unfortunatley only do not know how to get it merged now but it should be squashed. |
Description
Migration of
helpdesk_mgmtmodule from 18.0 to 19.0.This migration addresses the following Odoo 19.0 framework changes:
Mail Threading API Updates
_message_get_suggested_recipients()to accept flexible parameters using**kwargsfor compatibility with Odoo 19's varying parameter requirements_notify_get_reply_to()to include newauthor_idparameter_message_add_suggested_recipient()to_message_add_suggested_recipients()(plural) with updated signature usingemailparameter instead ofpartnerField Requirements
nameanddescriptionfields fromrequired=Truetorequired=Falseto support ticket creation via email (subject line populates these fields)OCA Compliance
Testing
Related Issues
Closes #xxx (if applicable - replace with actual issue number)