[FIX]pms: Refactor set_partner_address with more robust checks #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusVMayor
force-pushed
the
16.0_fix_set_partner_address
branch
2 times, most recently
from
2be2f09 to
f0e7d19
Compare
The method logic is refactored, avoiding updating data on every write operation and checking if the partner value is different, not just if it's set.
jesusVMayor
force-pushed
the
16.0_fix_set_partner_address
branch
from
f0e7d19 to
62d5d06
Compare
Member
|
/ocabot merge minor |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at a09b609. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method logic is refactored, avoiding updating data on every write operation and checking if the partner value is different, not just if it's set.