[18.0] [MIG] pos_session_pay_invoice by Tisho99 · Pull Request #1472 · OCA/pos

Tisho99 · 2026-01-12T10:40:09Z

Standard migration

The pos order is now created in draft state because we can no longer create pos payments in posted pos orders. The 'invoiced' state is assigned after that
The refund of the setUpClass is now generated from a new invoice because in v18 the original and refund moves were being automatically conciliated

T-9200

…module

Currently translated at 86.6% (26 of 30 strings) Translation: pos-14.0/pos-14.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_session_pay_invoice/es/

Currently translated at 100.0% (30 of 30 strings) Translation: pos-14.0/pos-14.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_session_pay_invoice/es/

Currently translated at 100.0% (30 of 30 strings) Translation: pos-14.0/pos-14.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_session_pay_invoice/it/

Currently translated at 100.0% (30 of 30 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

…rders createds with this module

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

…S session To prevent mistakes, users must select only the journals available in the pos.payment.method of the POS session.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

… customer transactions Before this commit, the wizard generated an account.bank.statement.line, but the problem was that when the POS had cash control enabled, all transactions generated by this wizard were displayed under Cash, because Odoo considered such statements as Cash In/Out operations, see https://github.com/odoo/odoo/blob/c1d3153ed564c0f47a201e5751740857a15d7db2/addons/point_of_sale/models/pos_session.py#L557-L567. Now, the transactions are shown under Cash or Bank depending on the payment method and journal type. For payments of vendor bills, a statement line will still be created, because the POS only works with receivable accounts and cannot reconcile with payable accounts. See https://github.com/odoo/odoo/blob/c1d3153ed564c0f47a201e5751740857a15d7db2/addons/point_of_sale/models/pos_order.py#L890-L898

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Currently translated at 100.0% (12 of 12 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

javierizaca

Functional review completed. The module works as expected, allowing payments to be made from the backend of an active session. LGTM.

pos_session_pay_invoice/__manifest__.py

ValentinVinagre · 2026-01-20T15:28:48Z

pos_session_pay_invoice/wizard/cash_pay_invoice.py

            "partner_id": self.invoice_id.partner_id.id,
            "account_move": self.invoice_id.id,
-            "state": "invoiced",
+            "state": "draft",


Is it validated at some point?

It is validated (or set as 'invoiced') here: https://github.com/OCA/pos/pull/1472/files#diff-f228ebf7313229f41451c1c8f72b80d566b40b9075e7fefd8dfac7313711e159R92

I searched for highet level function in pos.order to assign the state, but found anything useful for this case

Have you tried the following function 'action_pos_order_invoice' which calls '_generate_pos_order_invoice' which generates an invoice and marks the 'pos order' as invoiced?

https://github.com/odoo/odoo/blob/bcc1397c7d694dbe61ecbd44d0320b9518df84cb/addons/point_of_sale/models/pos_order.py#L984C9-L984C33

https://github.com/odoo/odoo/blob/bcc1397c7d694dbe61ecbd44d0320b9518df84cb/addons/point_of_sale/models/pos_order.py#L1010

We don't have to generate a new invoice, the invoice is already generated. We are associating a new pos order with an already created invoice. So using that function does not make sense for me

pos_session_pay_invoice/tests/test_pay_invoice.py

ValentinVinagre

LGTM 👍🏻

etobella and others added 30 commits January 9, 2026 14:44

[ADD] PoS session pay invoice module

9805efe

Migration of pos_session_pay_invoice to 11.0

afb4be1

Fix account-payment's github repo url

3be2f7a

[12.0][MIG] pos_session_pay_invoice

38c84a9

Added translation using Weblate (Spanish)

fa59c87

Added translation using Weblate (French)

6aa0a1b

[IMP] pos_session_pay_invoice: black, isort, prettier

aa080c9

[13.0][MIG] pos_session_pay_invoice

797170e

[MIG] pos_session_pay_invoice: Ending migration to 13.0

cbffa9e

[IMP] pos_session_pay_invoice: black, isort, prettier

8f77f09

[MIG] pos_session_pay_invoice: Migration to 14.0

3c7128c

[UPD] Update pos_session_pay_invoice.pot

b39a72c

Added translation using Weblate (Italian)

19da30a

[14.0][IMP] pos_session_pay_invoice: Set target=new on views

fd50081

[FIX] search_paid_order_ids must exclude orders createds with this …

5fdfa52

…module

[UPD] Update pos_session_pay_invoice.pot

dbd8e7f

pos_session_pay_invoice 14.0.1.1.0

b93726c

Translated using Weblate (Spanish)

222de9e

Currently translated at 86.6% (26 of 30 strings) Translation: pos-14.0/pos-14.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_session_pay_invoice/es/

Translated using Weblate (Spanish)

b832ffb

Currently translated at 100.0% (30 of 30 strings) Translation: pos-14.0/pos-14.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_session_pay_invoice/es/

Translated using Weblate (Italian)

f0bdec6

Currently translated at 100.0% (30 of 30 strings) Translation: pos-14.0/pos-14.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_session_pay_invoice/it/

[MIG] pos_session_pay_invoice: Migration to 16.0

c3e1c93

[UPD] Update pos_session_pay_invoice.pot

7dbb191

[BOT] post-merge updates

39ea0d8

Translated using Weblate (Italian)

3b03a4b

Currently translated at 100.0% (30 of 30 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

[FIX] pos_session_pay_invoice: search_paid_order_ids must exclude o…

9be617a

…rders createds with this module

[UPD] Update pos_session_pay_invoice.pot

55dd9f9

[BOT] post-merge updates

85dc654

Update translation files

ce0a30c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Translated using Weblate (Italian)

885b2c9

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

[IMP] pos_session_pay_invoice: Restrict to journals of the current PO…

398d5bc

…S session To prevent mistakes, users must select only the journals available in the pos.payment.method of the POS session.

oca-ci and others added 9 commits January 9, 2026 14:44

[UPD] Update pos_session_pay_invoice.pot

249bd53

[BOT] post-merge updates

804bc1e

Update translation files

a39d724

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

[UPD] Update pos_session_pay_invoice.pot

8e8a206

[BOT] post-merge updates

ef391d0

Update translation files

d8f4247

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/

Translated using Weblate (Italian)

f999a3d

Currently translated at 100.0% (12 of 12 strings) Translation: pos-16.0/pos-16.0-pos_session_pay_invoice Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_session_pay_invoice/it/

[IMP] pos_session_pay_invoice: pre-commit auto fixes

c1afe15

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch 3 times, most recently from 642bbe1 to 6bfe20c Compare January 16, 2026 14:18

Tisho99 marked this pull request as ready for review January 16, 2026 14:20

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch 2 times, most recently from dd612a9 to 868f215 Compare January 19, 2026 14:48

javierizaca approved these changes Jan 20, 2026

View reviewed changes

ValentinVinagre suggested changes Jan 20, 2026

View reviewed changes

Tisho99 added 2 commits January 21, 2026 17:18

[MIG] pos_session_pay_invoice: Migration to 18.0

6dabf01

[DON'T MERGE] test-requirements.txt

9d88a07

Tisho99 force-pushed the 18.0-mig-pos_session_pay_invoice branch from 868f215 to 9d88a07 Compare January 21, 2026 16:18

ValentinVinagre approved these changes Jan 22, 2026

View reviewed changes

OCA-git-bot added the approved label Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0] [MIG] pos_session_pay_invoice#1472

[18.0] [MIG] pos_session_pay_invoice#1472
Tisho99 wants to merge 41 commits intoOCA:18.0from
sygel-technology:18.0-mig-pos_session_pay_invoice

Tisho99 commented Jan 12, 2026 •

edited

Loading

Uh oh!

javierizaca left a comment

Uh oh!

Uh oh!

ValentinVinagre Jan 20, 2026

Uh oh!

Tisho99 Jan 21, 2026

Uh oh!

ValentinVinagre Jan 22, 2026

Uh oh!

Tisho99 Jan 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

ValentinVinagre left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

Tisho99 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javierizaca left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ValentinVinagre Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Tisho99 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

ValentinVinagre Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Tisho99 Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ValentinVinagre left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Tisho99 commented Jan 12, 2026 •

edited

Loading

Tisho99 Jan 22, 2026 •

edited

Loading