[19.0] [MIG] base_tier_validation: Migration to 19.0 #1189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu
…e and state correctly translated.
… has already benn addressed. * add a new point explaining review tooltip improvement possibilities.
Currently translated at 100.0% (59 of 59 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/zh_CN/
* fix test after the last forward-ported feature. * add a descrition of new know issue.
…of Eficent to ForgeFlow.
…. A customer or supplier can be a follower of the object and should not receive internal messages about the tier validation.
Currently translated at 100.0% (74 of 74 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/zh_CN/
Currently translated at 80.0% (60 of 75 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/es/
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/nl/
Changes done: - The subtypes should not be defined as default=True to avoid that a follower receives notifications of everything (even if he/she doesn't really need it). - When adding followers they are added to the corresponding subtype so that the notification arrives to whom it corresponds. - Improve the code so that the reviews to notify are the "following ones according to the sequence". TT56354
When an Odoo model inherits from `tier.validation` but sets up `_tier_validation_manual_config = True`, adding `review_ids` in a form view with the `tier_validation` widget causes Owl errors. It appears that the Tier Review fields are then not passed to the Owl framework, and accessing them in the widget template raises exceptions. Adding the fields used in the `base_tier_validation.Collapse` template to the component under the `relatedFields` key fixes this, while not changing the behavior for models using `_tier_validation_manual_config = False`.
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/it/
…it can be used in searchs. Similar to kevinkhao@217de7c TT56391
Odoo in V18 raises an error if the signature of the function is not strictly (cr, version). See: https://github.com/odoo/odoo/blob/2a839ef1ed09c36f27ce7536ca3052d9f65ceed9/odoo/modules/migration.py#L252-L256
…field-based validation
…in a one2many When the validations are in a model that is inside another model, after the reviews are approved, trying to open the one2many raises an error. This commit ensures that the value is taken from the correct record instead of env.model.root, which represents the main model and not the model that inherits tier.validation.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/it/
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/tr/
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/it/
pedrobaeza
requested changes
Nov 12, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
This should go to the new repository:
|
Hi @pedrobaeza , thank you for the heads-up. Regarding the move to the new OCA/tier-validation repository: Is there a current roadmap or estimated timeline for migrating the core base_tier_validation and its related modules (such as sale_tier_validation) over there? We are planning the migration for some clients who rely on these modules and would love to know if there is a specific date or plan, or if we could contribute to speed up the process. Thanks for your help! |
Member
|
I'm afraid it's not up to me. Ask the current contributor if they are going to move it, or fund them or original authors/contributors to do the migration with a deadline. |
|
Working on OCA/tier-validation#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.