[19.0] [mig] base_revision #1193

PaulaMForgeFlow · 2025-11-19T16:38:35Z

Standard migration

Currently translated at 92.3% (12 of 13 strings) Translation: server-ux-14.0/server-ux-14.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_revision/es/ Added translation using Weblate (Spanish)

…ttributes base_revision 14.0.1.0.1

…ld if it exists in the model. [UPD] Update base_revision.pot base_revision 14.0.1.1.0

[UPD] Update base_revision.pot [UPD] README.rst

[UPD] Update base_revision.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_revision/

base_revision 16.0.1.0.1 [fix] unit test in sale_order_revision fails base_revision 16.0.1.0.2 [UPD] README.rst

Translated using Weblate (Italian) Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-16.0/server-ux-16.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_revision/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/

Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/pt/

Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/it/

Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/tr/

JordiBForgeFlow · 2025-11-19T17:55:47Z

@pedrobaeza could you approve the workflows?

CRogos · 2026-02-06T13:22:33Z

@PaulaMForgeFlow could you review and add the change of #1237

CRogos

Nice work.

Some of the commits could be squashed.
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

see minor improvements below.

CRogos · 2026-02-06T13:38:49Z

base_revision/models/base_revision.py

+            "name": f"{self.unrevisioned_name}-{new_rev_number:02d}",
            "old_revision_ids": [(4, self.id, False)],


How about switching to:
"old_revision_ids": [Command.link(self.id)],

CRogos · 2026-02-06T13:40:30Z

base_revision/models/base_revision.py

            copied_rec = rec.copy_revision_with_context()
            if hasattr(self, "message_post"):
-                msg = _("New revision created: %s") % copied_rec.name
+                msg = self.env._("New revision created: %(name)s", name=copied_rec.name)


On new code I would agree using %(name)s but here it requires a new translation therefore we should stay with %s

see also my Changes in #1237

CRogos · 2026-02-09T10:18:04Z

base_revision/models/base_revision.py

+            # Calling  Copy method
+            copied_rec = rec.copy_revision_with_context()
+            if hasattr(self, "message_post"):
+                msg = self.env._("New revision created: %s") % copied_rec.name


I think we had a missunderstanding here. I think this is the best solution.

Suggested change

msg = self.env._("New revision created: %s") % copied_rec.name

msg = self.env._("New revision created: %s", copied_rec.name)

CRogos · 2026-02-09T12:55:30Z

@PaulaMForgeFlow could you review + add the changes of this PR: #1237

CRogos

LGTM

OCA-git-bot · 2026-02-09T15:49:12Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot and others added 21 commits November 19, 2025 15:03

[14.0][ADD] base_revision

1664971

[FIX] base_revision: auto_search and no_destroy are no longer valid a…

223ee46

…ttributes base_revision 14.0.1.0.1

[IMP] base_revision: Add revisions_count field + update the state fie…

14fb7ff

…ld if it exists in the model. [UPD] Update base_revision.pot base_revision 14.0.1.1.0

[MIG] base_revision: Migration to 15.0

55f2e64

[UPD] Update base_revision.pot [UPD] README.rst

[FIX] warning create method in batch

91c9aa0

base_revision 16.0.1.0.1 [fix] unit test in sale_order_revision fails base_revision 16.0.1.0.2 [UPD] README.rst

[IMP] base_revision: pre-commit stuff

0ef87c1

[MIG] base_revision: Migration to 17.0

22672c5

[UPD] Update base_revision.pot

23b46c3

[BOT] post-merge updates

86afa91

[MIG][18.0] base_revision: Migration to 18.0

8021ee8

[UPD] Update base_revision.pot

bd50f0c

[BOT] post-merge updates

7481d07

Update translation files

52c5035

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/

Added translation using Weblate (Portuguese)

440d5b2

Translated using Weblate (Portuguese)

e69aa38

Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/pt/

Translated using Weblate (Italian)

fe19ff2

Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/it/

Added translation using Weblate (Turkish)

dc457d2

Translated using Weblate (Turkish)

6d5d4f6

Currently translated at 100.0% (11 of 11 strings) Translation: server-ux-18.0/server-ux-18.0-base_revision Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_revision/tr/

PaulaMForgeFlow force-pushed the 19.0-mig-base_revision branch from d96c9e7 to 22e7842 Compare December 12, 2025 15:22

JordiBForgeFlow approved these changes Dec 12, 2025

View reviewed changes

MiquelRForgeFlow force-pushed the 19.0-mig-base_revision branch 6 times, most recently from c119cfd to d35fa06 Compare December 12, 2025 17:26

JordiBForgeFlow approved these changes Dec 12, 2025

View reviewed changes

CRogos reviewed Feb 6, 2026

View reviewed changes

PaulaMForgeFlow force-pushed the 19.0-mig-base_revision branch from d35fa06 to 9a1fa36 Compare February 9, 2026 09:37

CRogos reviewed Feb 9, 2026

View reviewed changes

PaulaMForgeFlow force-pushed the 19.0-mig-base_revision branch 2 times, most recently from 13bac8e to da9da5f Compare February 9, 2026 12:51

PaulaMForgeFlow force-pushed the 19.0-mig-base_revision branch from da9da5f to cf000b9 Compare February 9, 2026 14:52

[MIG] base_revision: Migration to 19.0

c020168

PaulaMForgeFlow force-pushed the 19.0-mig-base_revision branch from cf000b9 to c020168 Compare February 9, 2026 14:56

CRogos approved these changes Feb 9, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0] [mig] base_revision #1193

[19.0] [mig] base_revision #1193

Uh oh!

PaulaMForgeFlow commented Nov 19, 2025

Uh oh!

JordiBForgeFlow commented Nov 19, 2025

Uh oh!

CRogos commented Feb 6, 2026 •

edited

Loading

Uh oh!

CRogos left a comment

Uh oh!

CRogos Feb 6, 2026

Uh oh!

CRogos Feb 6, 2026 •

edited

Loading

Uh oh!

CRogos Feb 9, 2026

Uh oh!

CRogos commented Feb 9, 2026

Uh oh!

CRogos left a comment

Uh oh!

OCA-git-bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

		"name": f"{self.unrevisioned_name}-{new_rev_number:02d}",
		"old_revision_ids": [(4, self.id, False)],

	msg = self.env._("New revision created: %s") % copied_rec.name
	msg = self.env._("New revision created: %s", copied_rec.name)

Uh oh!

[19.0] [mig] base_revision #1193

Are you sure you want to change the base?

[19.0] [mig] base_revision #1193

Uh oh!

Conversation

PaulaMForgeFlow commented Nov 19, 2025

Uh oh!

JordiBForgeFlow commented Nov 19, 2025

Uh oh!

CRogos commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

CRogos Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

CRogos Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CRogos Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

CRogos commented Feb 9, 2026

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

CRogos commented Feb 6, 2026 •

edited

Loading

CRogos Feb 6, 2026 •

edited

Loading