Skip to content

[18.0][FIX] base_search_custom_field_filter: Error when define filters with related fields #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Feb 10, 2026
Merged

[18.0][FIX] base_search_custom_field_filter: Error when define filters with related fields #1232

OCA-git-bot merged 1 commit into from
Feb 10, 2026
+10 −11

Conversation

@CarlosRoca13
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 commented Jan 28, 2026

Steps to reproduce the behavior:

  1. Define a custom filter with . notation like partner_id.lang
  2. Access to the model defined, to check if we can use this filter.

An error was thrown

With this changes the field is defined in the correct point and the error is not thrown.

ping @pedrobaeza @carlos-lopez-tecnativa @mariancuadranetkia

cc @Tecnativa

This PR solves the Issue: #1231

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 28, 2026

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-FIX-base_search_custom_field_filter branch 2 times, most recently from b41ef8b to a5d1864 Compare January 28, 2026 11:08
mariancuadranetkia
mariancuadranetkia approved these changes Jan 28, 2026
View reviewed changes
Copy link

@mariancuadranetkia mariancuadranetkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested in runboat and now it's working.

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jan 28, 2026
@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 28, 2026

@carlosdauden can you check this?

@sergioM-S73 sergioM-S73 mentioned this pull request Feb 9, 2026
Open
sergioM-S73
sergioM-S73 approved these changes Feb 9, 2026
View reviewed changes
Copy link

@sergioM-S73 sergioM-S73 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍🏻
I added this commit in my migration to v19: #1238

@mariancuadranetkia
Copy link

mariancuadranetkia commented Feb 10, 2026

@pedrobaeza
I'm not sure if the errors detected in the test are only from translations. Is there any way we can help resolve this?

@CarlosRoca13
[FIX] base_search_custom_field_filter: Error when define filters with…
4f6e018 
… related fields

Steps to reproduce the behavior:

1. Define a custom filter with . notation like partner_id.lang
2. Access to the model defined, to check if we can use this filter.

An error was thrown

With this changes the field is defined in the correct point and the error is not thrown.
@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-FIX-base_search_custom_field_filter branch from a5d1864 to 4f6e018 Compare February 10, 2026 10:53
@CarlosRoca13
Copy link
Contributor Author

CarlosRoca13 commented Feb 10, 2026

Let's see if doing a rebase the problem is solved

@pedrobaeza
Copy link
Member

pedrobaeza commented Feb 10, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 10, 2026

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1232-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 10, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 6308fa8 into OCA:18.0 Feb 10, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 10, 2026

Congratulations, your PR was merged at 958f321. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-FIX-base_search_custom_field_filter branch February 10, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mariancuadranetkia mariancuadranetkia mariancuadranetkia approved these changes

@sergioM-S73 sergioM-S73 sergioM-S73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlosRoca13 @OCA-git-bot @pedrobaeza @mariancuadranetkia @sergioM-S73