[18.0][FIX] hr_shift: reduce crash when missing data#26
Open
[18.0][FIX] hr_shift: reduce crash when missing data#26
Conversation
Author
|
This pull request correct this crash. |
pedrobaeza
approved these changes
Feb 4, 2026
david-banon-tecnativa
approved these changes
Feb 4, 2026
Contributor
david-banon-tecnativa
left a comment
david-banon-tecnativa
left a comment
There was a problem hiding this comment.
LGTM, some minor comments
mathben
force-pushed
the
18.0_hr_shift_fix_first_execution
branch
from
465c906 to
877a47b
Compare
Author
|
@david-banon-tecnativa Thanks for your reviews, I implement your proposition. |
Contributor
|
Thanks, please force push again, CI failed but i don't think its related to the PR |
Member
|
I'm able to relaunch it, so I have done it. Let's see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last_plan can be False and default_vals can be empty
fix typo Self #25 (comment)