[FIX] sign_oca: correct syntax and handle js logic

[kobros-tech]

Role correct syntax is between {{ }} not ${}, this will cause error. parent.items[nextItem.id] if is not defined the function dispatchEvent will throw error in the UI, so it is better to handle that error.

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[AlvaroRM11]

LGTM

[pedrobaeza]

Please don't mix things in the same PR. I'm OK with the README change. If you publish it isolatedly, we can merge. But the other one is not clear how do you get to a situation where the element is not defined, and even if valid, you shouldn't log by console the warning. Just don't act.

[kobros-tech]

Please don't mix things in the same PR. I'm OK with the README change. If you publish it isolatedly, we can merge. But the other one is not clear how do you get to a situation where the element is not defined, and even if valid, you shouldn't log by console the warning. Just don't act.

just open my #99 and add a signature field when you fill it the error message will pop up, it is an error in UI not in the log.

and in my PR there is no JS there!

[pedrobaeza]

As said, please split both changes in 2 PRs for immediate merge of the README one, and the other shouldn't log to console.

[kobros-tech]

As said, please split both changes in 2 PRs for immediate merge of the README one, and the other shouldn't log to console.

All right I will split them

[kobros-tech]

As said, please split both changes in 2 PRs for immediate merge of the README one, and the other shouldn't log to console.

@pedrobaeza

#104 the readme one

[etobella]

For me it has sense

[pedrobaeza]

Enric, also the console.warn part?

[etobella]

Sorry, I didn't read your comment about the log 🤔

Well, it is clear that would be better to ignore it if not found, however, I don't see the problem in leaving the warn.

As both options work for me, I think that we should follow your suggestion and remove the warn. Can you do that @kobros-tech ?

[kobros-tech]

thank you both, sometimes I lose focus and I admit I just understood now what pedro said about consol log warn.
If I read the comment again I will understand, but when my head is overloading I can be slow to catch up.

I will work on it right now, some few please...

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-102-by-pedrobaeza-bump-patch, awaiting test results.

[kobros-tech]

the new module survey_sign_oca is ready for your review and comments, thanks!

@pedrobaeza
@etobella

[OCA-git-bot]

Congratulations, your PR was merged at ee49e9d. Thanks a lot for contributing to OCA. ❤️