Skip to content

Conversation

@smstone0
Copy link
Member

@smstone0 smstone0 commented Aug 29, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

What

Adds a config file to allow for the following:

  • Write data files locally instead of to S3.
  • Output logging messages to a local debug.log file.

This allows for better testing without effecting the cloud environments and in use data.

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

  • Yes
  • No
    Please write a brief description of why test coverage is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

  • Yes
  • No
    Please write a brief description of why documentation is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Related issues

KEH-1220 (Jira)

How to review

  • Follow README guide to run the Lambda locally outside of a container (link).
  • Change config.json to:
    {
      "features": {
        "show_log_locally": true,
        "write_data_locally": true
      }
    }
  • Run the tool.

Once the script has finished running, you should expect to see a debug.log file and an output/ directory containing the 3 json files that get written to S3.

Double check that all the files exist and they have data in them.

@smstone0 smstone0 marked this pull request as draft August 29, 2025 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
⚠️ BASH bash-exec 6 4 0 0.04s
✅ BASH shellcheck 6 0 0 0.12s
✅ BASH shfmt 6 0 0 0.01s
✅ CSHARP csharpier 1 0 0 0.58s
✅ DOCKERFILE hadolint 1 0 0 0.1s
✅ JSON jsonlint 2 0 0 0.18s
✅ JSON prettier 2 0 0 0.66s
✅ JSON v8r 2 0 0 3.43s
✅ MARKDOWN markdownlint 6 0 0 0.98s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.39s
✅ REPOSITORY checkov yes no no 26.25s
✅ REPOSITORY dustilock yes no no 0.02s
✅ REPOSITORY gitleaks yes no no 7.34s
✅ REPOSITORY grype yes no no 50.86s
✅ REPOSITORY kics yes no no 46.34s
✅ REPOSITORY secretlint yes no no 1.12s
✅ REPOSITORY syft yes no no 4.13s
✅ REPOSITORY trivy yes no no 12.65s
✅ REPOSITORY trivy-sbom yes no no 0.51s
✅ TERRAFORM terraform-fmt 6 0 0 0.47s
✅ YAML prettier 8 0 0 0.79s
✅ YAML v8r 8 0 0 6.37s
✅ YAML yamllint 8 0 0 0.54s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@TotalDwarf03 TotalDwarf03 marked this pull request as ready for review October 14, 2025 15:45
@TotalDwarf03 TotalDwarf03 requested a review from a team October 14, 2025 15:46
Copy link
Contributor

@sebtheo sebtheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@TotalDwarf03 TotalDwarf03 requested a review from mwirikia October 15, 2025 13:39
@TotalDwarf03 TotalDwarf03 requested a review from sebtheo October 15, 2025 13:39
@TotalDwarf03 TotalDwarf03 merged commit 27a201b into main Oct 27, 2025
5 checks passed
@TotalDwarf03 TotalDwarf03 deleted the KEH-1220 branch October 27, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants