-
Notifications
You must be signed in to change notification settings - Fork 1
KEH-1220 - Add config file support #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| bash-exec | 6 | 4 | 0 | 0.04s | ||
| ✅ BASH | shellcheck | 6 | 0 | 0 | 0.12s | |
| ✅ BASH | shfmt | 6 | 0 | 0 | 0.01s | |
| ✅ CSHARP | csharpier | 1 | 0 | 0 | 0.58s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.1s | |
| ✅ JSON | jsonlint | 2 | 0 | 0 | 0.18s | |
| ✅ JSON | prettier | 2 | 0 | 0 | 0.66s | |
| ✅ JSON | v8r | 2 | 0 | 0 | 3.43s | |
| ✅ MARKDOWN | markdownlint | 6 | 0 | 0 | 0.98s | |
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0.39s | |
| ✅ REPOSITORY | checkov | yes | no | no | 26.25s | |
| ✅ REPOSITORY | dustilock | yes | no | no | 0.02s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 7.34s | |
| ✅ REPOSITORY | grype | yes | no | no | 50.86s | |
| ✅ REPOSITORY | kics | yes | no | no | 46.34s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 1.12s | |
| ✅ REPOSITORY | syft | yes | no | no | 4.13s | |
| ✅ REPOSITORY | trivy | yes | no | no | 12.65s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.51s | |
| ✅ TERRAFORM | terraform-fmt | 6 | 0 | 0 | 0.47s | |
| ✅ YAML | prettier | 8 | 0 | 0 | 0.79s | |
| ✅ YAML | v8r | 8 | 0 | 0 | 6.37s | |
| ✅ YAML | yamllint | 8 | 0 | 0 | 0.54s |
See detailed report in MegaLinter reports
You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.
MegaLinter is graciously provided by OX Security
- Outputs logs to debug.log depending on config. - Standardise output directory to output/ - Cleanup misleading logging messages
- Prettier hates this but Megalinter love it :/
- tests for locally writing files - tests for get_team_history - tests for get_dict_value - tests for get_config_file
mwirikia
reviewed
Oct 15, 2025
mwirikia
reviewed
Oct 15, 2025
sebtheo
reviewed
Oct 15, 2025
Contributor
sebtheo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
sebtheo
approved these changes
Oct 20, 2025
mwirikia
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
Adds a config file to allow for the following:
This allows for better testing without effecting the cloud environments and in use data.
Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
KEH-1220 (Jira)
How to review
config.jsonto:{ "features": { "show_log_locally": true, "write_data_locally": true } }Once the script has finished running, you should expect to see a
debug.logfile and anoutput/directory containing the 3 json files that get written to S3.Double check that all the files exist and they have data in them.