Temperature-dependent thermal conductivity#26
Open
MattRolchigo wants to merge 2 commits intoORNL-MDF:mainfrom
Open
Temperature-dependent thermal conductivity#26MattRolchigo wants to merge 2 commits intoORNL-MDF:mainfrom
MattRolchigo wants to merge 2 commits intoORNL-MDF:mainfrom
Conversation
streeve
reviewed
Jan 3, 2025
Contributor
streeve
left a comment
streeve
left a comment
There was a problem hiding this comment.
We could keep the original version if it's a big slowdown
| // Thermal conductvity as a function of temperature in the form a + b * | ||
| // Temperature for solid and liquid. If only one value is given, fixed | ||
| // thermal conductivity for both phases are used | ||
| if ( db["properties"].contains( "thermal_conductivity_solid" ) && |
Contributor
There was a problem hiding this comment.
Are these inputs "Mist compatible"?
Collaborator
Author
There was a problem hiding this comment.
According to Steve, Mist supports having properties represented as polynomials in the Y = a + b*X format so I think we're good there
Collaborator
Author
|
@streeve What do you mean by "keep the original version"? Do we want that much more repeated code and an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also keeps the option to enter a single thermal conductivity value for backwards compatibility. Probably worth doing some optimization to keep the slowdown minimal