fix: QA and tests running until timeout because of missing count in while lo…

[JoshuaSBrown]

…op for query end to end test.

Ticket

 

Description

This PR fixes several problems with the logging output, as well as a number of bugs, and notably removal of prj/search route which is not used anywhere and shouldn't be. Includes fixing indentation problem with UUID that was causing an early return where a save was needed... among other items.

How Has This Been Tested?

Artifacts (if appropriate):

Tasks

• - A description of the PR has been provided, and a diagram included if it is a new feature.
• - Formatter has been run
• - CHANGELOG comment has been added
• - Labels have been assigned to the pr
• - A reviwer has been added
• - A user has been assigned to work on the pr
• - If new feature a unit test has been added

Summary by Sourcery

Bug Fixes:

• Ensure the query end-to-end test loop progresses toward its termination condition so tests no longer run until timeout.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the query end-to-end test loop now progresses its iteration counter so it can eventually terminate instead of running until timeout.

File-Level Changes

Change	Details	Files
Make the query E2E polling loop increment its iteration counter to avoid an infinite loop.	Add an increment of the loop counter inside the polling loop that waits for a material with alias starting with 'adamantium' Preserve the existing sleep-based polling behavior while ensuring the loop termination condition can be reached	tests/end-to-end/test_api_query.py

Possibly linked issues

• #unknown: PR increments the loop counter in the query end-to-end test, fixing the endless loop described in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since this loop is bounded by count, consider making the termination condition and increment more explicit (e.g., a for loop over a range or count += 1 with a clear max-iterations constant) to make the intent and safety of the retry logic easier to understand.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since this loop is bounded by `count`, consider making the termination condition and increment more explicit (e.g., a `for` loop over a range or `count += 1` with a clear max-iterations constant) to make the intent and safety of the retry logic easier to understand.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

New security issues found

[sourcery-ai]

New security issues found