Adding a verification system to verify benchmark results#111
Open
thomasRoglin wants to merge 3 commits intoORNL:masterfrom
Open
Adding a verification system to verify benchmark results#111thomasRoglin wants to merge 3 commits intoORNL:masterfrom
thomasRoglin wants to merge 3 commits intoORNL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a verification system inside the autohecbench.py allowing the benchmark results to be flagged as correct or not in the summary output.
In the subset.json, each benchmark entry now includes a verification section :
For now, only 2 verification types are supported :
no_verification: means that no verification is implemented / configuredverification_token: Takes two parameters:[success_token, fail_token].The benchmark output is considered valid if it contains the success_token at least once and the fail_token does not appear.
In the autohecbench.py script, we introduce a new argument
--verifythat will activate the verification.When enabled, the
run()function checks the verification type of the benchmark and performs the related verification.