Conversation
Collaborator
Author
schaefi
force-pushed
the
move_to_typer
branch
5 times, most recently
from
ace7dab to
fb35cbd
Compare
Collaborator
Author
|
@Conan-Kudo I'm mostly interested in getting the open questions from the checklist answered, so no need to do an in-depth review of the code changes as it's time consuming. Thanks much |
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 19, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 19, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 19, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 19, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
Member
|
We can't drop Python 3.9 support since that's required for CentOS/RHEL 9. |
Collaborator
Author
I found a fix to make it work on 3.9 too |
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-boxed-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-stackbuild-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-stackbuild-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-stackbuild-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
schaefi
added a commit
to OSInside/kiwi-stackbuild-plugin
that referenced
this pull request
Mar 20, 2025
In addition to docopt also support the typer commandline interface. This is relevant for kiwi versions that has moved to typer. OSInside/kiwi#2751
Collaborator
Author
|
@Conan-Kudo I finished the Cli change and also updated the plugins. The plugins continues to support both docopt and typer such that they can continue to work also with older versions of kiwi. The upstream kiwi should change to typer and the interface is a drop-in-replacement such that there should be no difference in the former caller semantic. The only open question is if the typer python module is available in all distros we support. I did a short test on Virtualization:Appliances:Staging/python-kiwi and it would build the package for all targets that exists there except for ALP which is an issue that I need to resolve prior merge Also I appreciate your feedback with regards to the other OS'es Thanks |
Collaborator
Author
|
And there is also the question on the min version of typer in the pyproject.toml to be ok or not |
Conan-Kudo
requested changes
Mar 20, 2025
schaefi
force-pushed
the
move_to_typer
branch
2 times, most recently
from
134d296 to
f8234e1
Compare
schaefi
force-pushed
the
move_to_typer
branch
from
cce4d97 to
e1a723e
Compare
schaefi
force-pushed
the
move_to_typer
branch
from
e1a723e to
1594575
Compare
schaefi
force-pushed
the
move_to_typer
branch
from
1594575 to
8ecf59b
Compare
schaefi
force-pushed
the
move_to_typer
branch
from
8ecf59b to
80c2814
Compare
schaefi
force-pushed
the
move_to_typer
branch
from
80c2814 to
551dad4
Compare
Collaborator
Author
|
schaefi
force-pushed
the
move_to_typer
branch
4 times, most recently
from
b50ee15 to
e997a4e
Compare
schaefi
force-pushed
the
move_to_typer
branch
2 times, most recently
from
59bb2cc to
83ce951
Compare
Collaborator
Author
from the |
This commit moves the kiwi commandline and plugin interface to typer and drops the use of docopt. Typer is based on python type hints and allows for a more modern way to define Cli interfaces and auto completion, even for plugins. Also docopt is split into an old and a next generation variant and allows us to get rid of spec file hacks as well as documentation rendering hacks.
See in code comment for the reason
ca-target-distribution only allows a set of static values. Make sure to enforce this validation at the option evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the kiwi commandline and plugin interface to
typerand drops the use ofdocopt. Typer is based on python type hints and allows for a more modern way to define Cli interfaces and auto completion, even for plugins. Also docopt is split into an old and a next generation variant and allows us to get rid of spec file hacks as well as documentation rendering hacks.