WIP: Add VMware Vagrant Provider Support#2827
WIP: Add VMware Vagrant Provider Support#2827NeilHanlon wants to merge 4 commits intoOSInside:mainfrom
Conversation
|
n.b., I know I need tests and to fix existing ones :D |
try and pull in the generated vmx file
d798231 to
ef721bc
Compare
|
@NeilHanlon Hi, this looks great. Thanks much for the effort 👍
yay :) once this is all green I'm very happy to merge it. I wrote some documentation about the vagrant use case in the past. You can find this here
I believe it would be good to add some information about the new provider and how to use it there too. Thoughts ? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed as part of the community meeting. |
|
@NeilHanlon I guess you are also still working on this one ? |
|
Please let us know if you won't continue the effort. Thanks much |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed as part of the community meeting. |
This change introduces support for the
vmware_desktopprovider in Vagrant by generating a VMDK using the Vagrant subformat and embedding it into the resulting Vagrant box.It also adds support for
aarch64VMware disks (and therefore, boxes) by enabling a sata option for the machine.vmdisk.controller attribute. This option is passed through to the VMware template while preserving the default IDE-based configuration for existing use cases.Additionally, a pcibridge0 section has been added to the generated VMX configuration. This was required during testing to ensure the resulting image functioned properly.
Lastly, the
vagrant_post_initmethod signature was updated to allow passing extra configuration options (custom_args) into the VMDK creation process, enabling more flexible build customization. Incidently, a type alias for theVagrantConfigDict(Dict['str', xml_parse.vagrantconfig]) was added to clean up long lines.