Skip to content

Add plymouth_msg #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uecasm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add plymouth_msg #2935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions dracut/modules.d/55kiwi-repart/kiwi-repart-disk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ function get_target_rootpart_size {
echo "${kiwi_oemrootMB}"
}

function plymouth_msg {
if command -v plymouth >/dev/null 2>&1; then
Copy link
Collaborator

@schaefi schaefi Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to

if command -v plymouth &>/dev/null; then
    :
fi

or

if type plymouth &>/dev/null; then
    :
fi

as you prefer. Thanks

plymouth display-message --text="$1"
fi
}

function repart_standard_disk {
# """
# repartition disk with read/write root filesystem
Expand Down Expand Up @@ -322,6 +328,8 @@ if ! resize_wanted "${last_device}" "${disk}"; then
return
fi

plymouth_msg "Expanding disk..."
Copy link
Collaborator

@schaefi schaefi Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you want to expose the messages also to the framebuffer if plymouth is enabled. However, I believe we should not duplicate different messages depending on where they are displayed.

In the kiwi dracut code I'm using the dracut provided messaging system. You can see this when looking for

warn "..."
info "..."

kind a like messages. I believe it would be good if we check if dracut itself is not already capable to show this as plymouth message and if not I would propose that we create our own warn , info functions which wraps the dracut provided ones and also calls your code to display the same message also through plymouth.

This way we still have the same messages but just stream them to different channels.

Thoughts ?

Copy link
Collaborator

@schaefi schaefi Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You find the implementation of the messaging system in dracut at ./99base/dracut-lib.sh


# prepare disk for repartition
if [ "$(get_partition_table_type "${disk}")" = 'gpt' ];then
relocate_gpt_at_end_of_disk "${disk}"
Expand Down Expand Up @@ -358,5 +366,7 @@ else
resize_filesystem "$(get_root_map)"
fi

plymouth_msg ""

# wait for the root device to appear
wait_for_storage_device "${last_device}"